Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate x/paramfilter in favor of ante handler #4202

Open
rootulp opened this issue Jan 10, 2025 · 0 comments
Open

Deprecate x/paramfilter in favor of ante handler #4202

rootulp opened this issue Jan 10, 2025 · 0 comments
Labels
consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules refactor optional label for items that are related to implementation work and do not change functionality

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jan 10, 2025

Context

Binary Builders is working on upgrading the SDK to v0.52.x. See https://github.com/01builders/celestia-app/blob/sdk-v0.52.x/binary.md for progress updates

Problem

They're hitting an issue with the existing x/paramfilter

Goal #11: Wire circuit breaker to block some (staking & bank) MsgUpdateParams now that x/paramfilter is removed

Proposal

Refactor the x/paramfilter module to be an ante handler. The ante handler should reject txs that attempt to modify any of these governance params

celestia-app/app/app.go

Lines 766 to 779 in 29d4409

// BlockedParams returns the params that require a hardfork to change, and
// cannot be changed via governance.
func (app *App) BlockedParams() [][2]string {
return [][2]string{
// bank.SendEnabled
{banktypes.ModuleName, string(banktypes.KeySendEnabled)},
// staking.UnbondingTime
{stakingtypes.ModuleName, string(stakingtypes.KeyUnbondingTime)},
// staking.BondDenom
{stakingtypes.ModuleName, string(stakingtypes.KeyBondDenom)},
// consensus.validator.PubKeyTypes
{baseapp.Paramspace, string(baseapp.ParamStoreKeyValidatorParams)},
}
}

cc: @julienrbrt

@rootulp rootulp added consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules refactor optional label for items that are related to implementation work and do not change functionality labels Jan 10, 2025
julienrbrt added a commit to 01builders/celestia-app that referenced this issue Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules refactor optional label for items that are related to implementation work and do not change functionality
Projects
None yet
Development

No branches or pull requests

1 participant