Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a delay between MsgTryUpgrade and upgrade height #3552

Closed
rootulp opened this issue Jun 11, 2024 · 0 comments · Fixed by #3560
Closed

Add a delay between MsgTryUpgrade and upgrade height #3552

rootulp opened this issue Jun 11, 2024 · 0 comments · Fixed by #3560
Assignees
@rootulp
Labels
WS: V2 ✌️ lemongrass hardfork related

Comments

@rootulp
Copy link
Collaborator

rootulp commented Jun 11, 2024

Context

Informal Systems v2 audit finding 3.

Problem

A user can submit a MsgTryUpgrade as soon as 5/6 voting power has signaled for a version. The remaining 1/6 of voting power won't have any time to upgrade prior to the upgrade height.

Proposal

Add a delay between the block that includes a successful MsgTryUpgrade and the upgrade height.

  1. Determine a reasonable delay time period. Ex: 2 days or 1 week.
  2. Add the delay. Note: during this time all signals and future cranks should be no-ops.
@rootulp rootulp added the WS: V2 ✌️ lemongrass hardfork related label Jun 11, 2024
@rootulp rootulp self-assigned this Jun 12, 2024
@rootulp rootulp mentioned this issue Jun 12, 2024
Merged
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@rootulp @staheri14
feat!: add a delay between quorum and upgrade height (#3560)
0abc021 
Closes celestiaorg/celestia-app#3552

Ready for review but I won't merge until we reach social consensus on
what the upgrade height delay should be.

## Testing

Manually tested the new CLI commands by staring single node script and
then:

```shell
$ celestia-appd query signal upgrade
no upgrade is pending.

$ celestia-appd tx signal signal 3 --from $VALIDATOR --fees $DEFAULT_FEES --broadcast-mode $BROADCAST_MODE --yes

$ celestia-appd tx signal try-upgrade  --from $VALIDATOR --fees $DEFAULT_FEES --broadcast-mode $BROADCAST_MODE --yes

$ celestia-appd query signal upgrade
upgrade is pending to app version 3 at height 151345.
```

---------

Co-authored-by: Sanaz Taheri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
WS: V2 ✌️ lemongrass hardfork related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: add a delay between quorum and upgrade height rootulp/celestia-app
1 participant
@rootulp