Populate consensus_params.version for exported app
#3472
Labels
good first issue
Good for newcomers
Comments
Merged
rootulp
added a commit
that referenced
this issue
May 14, 2024
Closes #3392 Opens #3472 Fixes a few bugs: 1. Previously all modules had `ExportGenesis` invoked on them even if they weren't supported by the current app version. Now we only call `ExportGenesis` for the modules that are supported by the current app version 2. The export command wasn't updated to account for the changes in #3320 which force us to mount stores after `app.New()` based on the current app version 3. The minfee module couldn't be exported b/c it didn't register a key table in `ExportGenesis` ## Testing I could export an app on app version 1 and 2. See [output](https://gist.github.com/rootulp/dfea2b5b40f7366b03706fc39321ceee)
This was referenced Jul 2, 2024
0xchainlover
pushed a commit
to celestia-org/celestia-app
that referenced
this issue
Aug 1, 2024
Closes celestiaorg/celestia-app#3392 Opens celestiaorg/celestia-app#3472 Fixes a few bugs: 1. Previously all modules had `ExportGenesis` invoked on them even if they weren't supported by the current app version. Now we only call `ExportGenesis` for the modules that are supported by the current app version 2. The export command wasn't updated to account for the changes in celestiaorg/celestia-app#3320 which force us to mount stores after `app.New()` based on the current app version 3. The minfee module couldn't be exported b/c it didn't register a key table in `ExportGenesis` ## Testing I could export an app on app version 1 and 2. See [output](https://gist.github.com/rootulp/dfea2b5b40f7366b03706fc39321ceee)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Context
#3450 fixed a few issues to make it possible to invoke
celestia-appd exportProblem
The exported output doesn't populate
consensus_params.versionNote: this isn't a big deal b/c we could populate this field manually.
Proposal
Populate the
consensus_params.versionfield for an exported app.The text was updated successfully, but these errors were encountered: