Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differentiate blob share ante handler based on app version #3468

Closed
rootulp opened this issue May 12, 2024 · 0 comments · Fixed by #3479
Closed

Differentiate blob share ante handler based on app version #3468

rootulp opened this issue May 12, 2024 · 0 comments · Fixed by #3479
Assignees
@rootulp
Labels
priority:high optional label to track the relative priority of planned items WS: V2 ✌️ lemongrass hardfork related

Comments

@rootulp
Copy link
Collaborator

rootulp commented May 12, 2024

Context

#3082 introduced a breaking change to the behavior of an ante handler.

Problem

The change in that PR isn't gated based on app versions. Since we expect some nodes to upgrade to a v2 binary prior to the v2 upgrade height, the change in that PR needs to be modified to be gated based on app version.

Proposal

Modify the ante handler change to be gated based on app version.

  • For app version v1, nodes should use the previous implementation of that ante handler.
  • For app version v2, nodes should use the fixed implementation of that ante handler.
@rootulp rootulp added WS: V2 ✌️ lemongrass hardfork related priority:high optional label to track the relative priority of planned items labels May 12, 2024
@rootulp rootulp self-assigned this May 14, 2024
@rootulp rootulp mentioned this issue May 14, 2024
Merged
@coderabbitai coderabbitai bot mentioned this issue Jul 3, 2024
Merged
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@rootulp @rach-id
chore: revive max blob size decorator (#3479)
57834e7 
Closes celestiaorg/celestia-app#3468 by
reviving the max blob size decorator and making both decorators version
aware so that:
- v1 uses max blob size decorator
- v2 uses max blob share decorator

---------

Co-authored-by: CHAMI Rachid <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
priority:high optional label to track the relative priority of planned items WS: V2 ✌️ lemongrass hardfork related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: revive max blob size decorator rootulp/celestia-app
1 participant
@rootulp