Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability test rapid voting power changes #2382

Open
evan-forbes opened this issue Aug 29, 2023 · 1 comment
Open

Add the ability test rapid voting power changes #2382

evan-forbes opened this issue Aug 29, 2023 · 1 comment
Labels
testing items that are strictly related to adding or extending test coverage

Comments

@evan-forbes
Copy link
Member

the light clients need to have the ability to test against rapid voting power changes in a test environment. This might involve simply swapping the key used by the single validator in testnode or by adding the ability to run a second node in process.
@evan-forbes evan-forbes added the testing items that are strictly related to adding or extending test coverage label Aug 29, 2023
@renaynay renaynay mentioned this issue Aug 29, 2023
Merged
renaynay added a commit to celestiaorg/celestia-node that referenced this issue Aug 30, 2023
@Wondertan @renaynay
chore: bump go-header and go-fraud (#2619)
9d663cf 
This PR bumps go-header and go-fraud which are both breaking - lots of
changes here so please review carefully.

Note that this also contains re-introduction of
VerifyCommitLightTrusting which caused us issues in `mocha` due to rapid
voting power changes. At the moment, there are no test utilities to test
that specific case, so we need to wait to roll it out to `mocha`.

Related: celestiaorg/celestia-app#2382

---------

Co-authored-by: rene <[email protected]>
@evan-forbes evan-forbes mentioned this issue Sep 20, 2023
Closed
6 tasks
walldiss pushed a commit to walldiss/celestia-node that referenced this issue Sep 22, 2023
@Wondertan @walldiss
chore: bump go-header and go-fraud (celestiaorg#2619)
f216647 
This PR bumps go-header and go-fraud which are both breaking - lots of
changes here so please review carefully.

Note that this also contains re-introduction of
VerifyCommitLightTrusting which caused us issues in `mocha` due to rapid
voting power changes. At the moment, there are no test utilities to test
that specific case, so we need to wait to roll it out to `mocha`.

Related: celestiaorg/celestia-app#2382

---------

Co-authored-by: rene <[email protected]>
(cherry picked from commit 9d663cf)
walldiss pushed a commit to celestiaorg/celestia-node that referenced this issue Sep 22, 2023
@Wondertan @walldiss
chore: bump go-header and go-fraud (#2619)
a2e4aaf 
This PR bumps go-header and go-fraud which are both breaking - lots of
changes here so please review carefully.

Note that this also contains re-introduction of
VerifyCommitLightTrusting which caused us issues in `mocha` due to rapid
voting power changes. At the moment, there are no test utilities to test
that specific case, so we need to wait to roll it out to `mocha`.

Related: celestiaorg/celestia-app#2382

---------

Co-authored-by: rene <[email protected]>

(cherry picked from commit 9d663cf)
@cmwaters
Copy link
Contributor

What exactly are we trying to assess here. Is it that we can still validate headers even if there's been a validator set change greater than 1/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing items that are strictly related to adding or extending test coverage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmwaters @evan-forbes