Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPIC: Hard capped blocksize #1592

Closed
evan-forbes opened this issue Apr 2, 2023 · 0 comments
Closed

EPIC: Hard capped blocksize #1592

evan-forbes opened this issue Apr 2, 2023 · 0 comments
Assignees
Labels
consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules

Comments

@evan-forbes
Copy link
Member

We want the ability to configure the square size via token voting, but with hard cap that requires a hardfork to change. In previous discussions, we've decided to simply use the consensus param of max block size to limit the max block size. However, the hardcoded limit is still the max square size (currently 128 as of writing), which gets hit at ~6-7MB.

We should still make the block size limited by the consensus param, and we don't want to go above a 128x128 square size (ods). This will likely involve setting the default block size consensus param to the maximum value that can fit in a 128x128 square.

related to #1569 in that we are wanting to hardcode a max parameter.

blocked by #1214 because that removes the estimation logic, which would probably be used to limit the square size

@evan-forbes evan-forbes added the consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules label Apr 2, 2023
@evan-forbes evan-forbes added this to the Mainnet milestone Apr 2, 2023
evan-forbes added a commit that referenced this issue May 17, 2023
…ze (#1761)

## Overview

The base implementation for all ADR021 #1759 options

part of #1592 
blocked by #1754

## Checklist

- [x] New and updated code has appropriate documentation
- [x] New and updated code has new and/or updated testing
- [x] Required CI checks are passing
- [x] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords
@evan-forbes evan-forbes moved this from Todo to Done in Engineering Team Epics Jun 11, 2023
@evan-forbes evan-forbes self-assigned this Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules
Projects
Development

Successfully merging a pull request may close this issue.

1 participant