Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPIC: Strict inflation schedule #1570

Closed
evan-forbes opened this issue Mar 30, 2023 · 2 comments
Closed

EPIC: Strict inflation schedule #1570

evan-forbes opened this issue Mar 30, 2023 · 2 comments
Assignees
@rootulp @mojtaba-esk
Labels
epic item groups other items for easier tracking

Comments

@evan-forbes
Copy link
Member

We will be using a simplified inflation schedule that is strict. We start at 8%, decrease 10% each year, and end at 1.5%
@evan-forbes evan-forbes added the epic item groups other items for easier tracking label Mar 30, 2023
@evan-forbes evan-forbes added this to the Mainnet milestone Mar 30, 2023
@evan-forbes evan-forbes mentioned this issue Apr 2, 2023
Closed
@evan-forbes evan-forbes moved this to In Progress in Engineering Team Epics Apr 10, 2023
@rootulp rootulp self-assigned this Apr 20, 2023
This was referenced Apr 20, 2023
Merged
Merged
rootulp added a commit that referenced this issue May 17, 2023
@mojtaba-esk @rootulp
@evan-forbes @cmwaters
feat: strict inflation schedule (#1578)
207ec1a 
### Description

Part of #1570
Implement the strict inflation schedule specified in
#1584

### Remaining tasks
- [x] implement inflation rate change based on block timestamp rather
than block height
- [x] set genesis time in x/mint state
- [x] move `MintDenom` from param to `x/mint` state
- [x] remove `TestRandomizedGenState`
- [x] investigate why `TestQueryGRPC` / other integration tests are
never run
- [x] write a test that 1. starts a new chain, 2. verifies state of
x/mint module for first few blocks, 3. skips ahead to a block one year
later, 4. verifies inflation rate went down a bit
- [x] remove `Params` entirely
- [x] annual provisions for a year should be based on total supply at
the beginning of that year
- [x] for time-based inflation, calculate block provision as current
block timestamp - previous block timestamp = seconds elapsed / seconds
in a year * annual provisions for a year
- [x] remove `BlocksPerYear`
- [x] elaborate in README.md

### FLUPs

- #1755
- #1757
- #1758
- #1756

---------

Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Evan Forbes <[email protected]>
Co-authored-by: Callum Waters <[email protected]>
@rootulp
Copy link
Collaborator

rootulp commented May 17, 2023

rootulp added a commit that referenced this issue May 23, 2023
@mojtaba-esk @rootulp
docs: ADR 019 strict inflation schedule (#1584)
34e18f1 
ADR for #1570

---------

Co-authored-by: Rootul P <[email protected]>
rach-id pushed a commit to rach-id/celestia-app that referenced this issue May 23, 2023
@mojtaba-esk @rootulp @rach-id
docs: ADR 019 strict inflation schedule (celestiaorg#1584)
c5432c8 
ADR for celestiaorg#1570

---------

Co-authored-by: Rootul P <[email protected]>
@rootulp rootulp moved this from In Progress to Done in Engineering Team Epics Jun 6, 2023
@rootulp
Copy link
Collaborator

rootulp commented Jun 6, 2023

Closing this epic b/c the ADR and implementation merged.

@rootulp rootulp closed this as completed Jun 6, 2023
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@mojtaba-esk @rootulp
@evan-forbes @cmwaters
feat: strict inflation schedule (#1578)
e870412 
### Description

Part of celestiaorg/celestia-app#1570
Implement the strict inflation schedule specified in
celestiaorg/celestia-app#1584

### Remaining tasks
- [x] implement inflation rate change based on block timestamp rather
than block height
- [x] set genesis time in x/mint state
- [x] move `MintDenom` from param to `x/mint` state
- [x] remove `TestRandomizedGenState`
- [x] investigate why `TestQueryGRPC` / other integration tests are
never run
- [x] write a test that 1. starts a new chain, 2. verifies state of
x/mint module for first few blocks, 3. skips ahead to a block one year
later, 4. verifies inflation rate went down a bit
- [x] remove `Params` entirely
- [x] annual provisions for a year should be based on total supply at
the beginning of that year
- [x] for time-based inflation, calculate block provision as current
block timestamp - previous block timestamp = seconds elapsed / seconds
in a year * annual provisions for a year
- [x] remove `BlocksPerYear`
- [x] elaborate in README.md

### FLUPs

- celestiaorg/celestia-app#1755
- celestiaorg/celestia-app#1757
- celestiaorg/celestia-app#1758
- celestiaorg/celestia-app#1756

---------

Co-authored-by: Rootul P <[email protected]>
Co-authored-by: Evan Forbes <[email protected]>
Co-authored-by: Callum Waters <[email protected]>
0xchainlover pushed a commit to celestia-org/celestia-app that referenced this issue Aug 1, 2024
@mojtaba-esk @rootulp
docs: ADR 019 strict inflation schedule (#1584)
508290f 
ADR for celestiaorg/celestia-app#1570

---------

Co-authored-by: Rootul P <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

@mojtaba-esk mojtaba-esk

Labels
epic item groups other items for easier tracking
Projects
Engineering Team Epics
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rootulp @mojtaba-esk @evan-forbes