Annotate abstract.py
#1522
Merged
Annotate abstract.py
#1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
Why is there a bot that commits on my branch... |
Kludex
force-pushed
the
annotate/abstract
branch
from
d500c39 to
c588c27
Compare
auvipy
requested changes
Apr 12, 2022
There was a problem hiding this comment.
please rebase & try to reduce the usage of Any types https://sethmlarson.dev/blog/tests-arent-enough-case-study-after-adding-types-to-urllib3#anything-but-any
Kludex
commented
May 4, 2022
kombu/abstract.py
Outdated
|
|
||
| def unpickle_dict(cls, kwargs): | ||
| def unpickle_dict( | ||
| cls: Type[_ObjectType], kwargs: Dict[str, Any] |
kombu/abstract.py
Outdated
| @@ -23,9 +37,9 @@ class Object: | |||
| Supports automatic kwargs->attributes handling, and cloning. | |||
| """ | |||
|
|
|||
| attrs = () | |||
| attrs: Tuple[Tuple[str, Any], ...] = () | |||
There was a problem hiding this comment.
The thing here is that each attr can really be Any, and str is the name of the attr. It looks fine as well.
| def as_dict(self, recurse=False): | ||
| def f(obj, type): | ||
| def as_dict(self, recurse: bool = False) -> Dict[str, Any]: | ||
| def f(obj: Any, type: Callable[[Any], Any]) -> Any: |
There was a problem hiding this comment.
Here is the only place that we can try to improve... I'm not sure what can be a good replacement tho...
|
rebased 👍 |
auvipy
approved these changes
May 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1511