Skip to content

Allow pytest 9 #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cjwatson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Allow pytest 9 #986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements/test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ pytest-timeout

# Conditional dependencies
pytest>=6.2.5,<8.0; python_version < '3.9' # Python 3.8 only
pytest>=6.2.5,<9.0; python_version >= '3.9' # Python 3.9+ only
pytest>=6.2.5,<10.0; python_version >= '3.9' # Python 3.9+ only
pytest-django>=4.5.2,<4.6.0; python_version < '3.9' # Python 3.8 only
pytest-django>=4.5.2,<5.0; python_version >= '3.9' # Python 3.9+ only
backports.zoneinfo; python_version < '3.9' # Python 3.8 only
3 changes: 0 additions & 3 deletions t/unit/test_schedulers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,6 @@ def test_task_with_expires(self):
class test_DatabaseSchedulerFromAppConf(SchedulerCase):
Scheduler = TrackingScheduler

@pytest.mark.django_db
Copy link
Member

@auvipy auvipy Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removing this?

Copy link
Author

@cjwatson cjwatson Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link I posted in the issue description explains it. This is a mark applied to a fixture function. With pytest<9 it was a no-op; with pytest>=9 it is an error. It doesn't matter what the mark is.

The mark that actually matters is the one applied to the class, which my PR doesn't touch.

@pytest.fixture(autouse=True)
def setup_scheduler(self, app):
self.app = app
Expand Down Expand Up @@ -617,7 +616,6 @@ def test_periodic_task_model_schedule_type_change(self):
class test_DatabaseScheduler(SchedulerCase):
Scheduler = TrackingScheduler

@pytest.mark.django_db
@pytest.fixture(autouse=True)
def setup_scheduler(self, app):
self.app = app
Expand Down Expand Up @@ -1588,7 +1586,6 @@ def test_track_changes(self):

@pytest.mark.django_db
class test_modeladmin_PeriodicTaskAdmin(SchedulerCase):
@pytest.mark.django_db
@pytest.fixture(autouse=True)
def setup_scheduler(self, app):
self.app = app
Expand Down
Loading