Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove seen before concept and use toggle concept instead #169

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Remove seen before concept and use toggle concept instead #169

merged 4 commits into from
Sep 25, 2023

Conversation

LauJosefsen
Copy link
Contributor

@LauJosefsen LauJosefsen commented Sep 22, 2023 •
edited
Loading

Use a toggle file instead of a disable file.

Should prevent caching of disabled projects, and only save user choices.

Format:

projecta:true -- enables projecta
projectb:false -- disables projectb

firecow
firecow approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@firecow firecow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @LauJosefsen Niza has a question.

@LauJosefsen LauJosefsen merged commit 07af04c into main Sep 25, 2023
8 checks passed
@LauJosefsen LauJosefsen deleted the remove-seen-before-concept-and-use-toggle-concept-instea branch September 25, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nizacegodk nizacegodk nizacegodk left review comments

@firecow firecow firecow approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LauJosefsen @firecow @nizacegodk