Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Propel\om folder in source #1

Open
xyanide opened this issue Sep 3, 2012 · 6 comments
Open

Missing Propel\om folder in source #1

xyanide opened this issue Sep 3, 2012 · 6 comments

Comments

@xyanide
Copy link

xyanide commented Sep 3, 2012

I think some stuff is missing in your ogone bundle.
I cant seem to find the use Cedriclombardot\OgonePaymentBundle\Propel\om\BaseOgoneOrder; file, or any file located in the propel\om folder (as the folder doesnt exist).

Another question I have, is this bundle usable without the use of propel? Because i`m seeing a lot of propel references everywhere.

@cedriclombardot
Copy link
Owner

Thats normal, the best practice consist to ignore generated files by propel like that when you built them with your own behaviors it will be integrated in your environement.

This bundle works only with propel for the moment. But i think it could be a good things to make it compatible with other ORMs

@xyanide
Copy link
Author

xyanide commented Sep 3, 2012

Could you then make it possible to let us handle the order / client handling and just provide the ogone logic?
This would make it a lot easier for other projects to implement your bundle with their logic.

@xyanide xyanide closed this as completed Sep 3, 2012
@xyanide xyanide reopened this Sep 3, 2012
@cedriclombardot
Copy link
Owner

I think it's important to keep a link with db, creating order .. but what
could be good its to enable with DI the way to override mobel classes used
to create order
https://github.com/cedriclombardot/OgonePaymentBundle/blob/master/Builder/TransactionBuilder.php#L22,
transactions and aliases.

For me the ogone implementation without ORM/ODM have no interrest, but let
choose your ORM and why not your models object with the bundles override
and the DI is the solution

@xyanide
Copy link
Author

xyanide commented Sep 3, 2012

Indeed, that might also be a good solution.
This way we can implement our own logic and still use your bundle.

@cedriclombardot
Copy link
Owner

Yes Can you propose a pull request with thoses changes ?

2012/9/3 xyanide [email protected]

Indeed, that might also be a good solution.
This way we can implement our own logic and still use your bundle.


Reply to this email directly or view it on GitHubhttps://github.com//issues/1#issuecomment-8236719.

@xyanide
Copy link
Author

xyanide commented Sep 3, 2012

Im already using another bundle as modifying this bundle would cost me too much time with the timeschedule were dealing with.

I`m now using the following bundle: https://github.com/marlon-be/marlon-ogone
This works out of the box for me and allows me to use my backend logic right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants