Merged
Conversation
✅ Deploy Preview for cedarjs canceled.
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many -t build:pack --exclude create-ceda... |
✅ Succeeded | 2s | View ↗ |
nx run-many -t build |
✅ Succeeded | 3m 35s | View ↗ |
nx run-many -t test --minWorkers=1 --maxWorkers=4 |
✅ Succeeded | 4m 15s | View ↗ |
nx run-many -t test:types |
✅ Succeeded | 9s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-01-30 15:14:41 UTC
Contributor
Greptile OverviewGreptile SummaryThis PR standardizes TypeScript configuration values to use lowercase, aligning with TypeScript's official documentation and IDE intellisense conventions. Changes Made
Files Updated
Impact
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant CLI as Cedar CLI
participant Handler as packageHandler.js
participant FS as File System
participant TS as TypeScript Parser
Dev->>CLI: Generate new package
CLI->>Handler: updateTsconfig()
loop For each target (api, web, scripts)
Handler->>FS: Read tsconfig.json
FS-->>Handler: Return config text
Handler->>TS: parseConfigFileTextToJson()
TS-->>Handler: Parsed config object
alt Has module config
Handler->>Handler: currentModule.toLowerCase()
Handler->>Handler: Check if acceptable value
alt Not acceptable
Handler->>Handler: modify() with lowercase value<br/>(node20, esnext)
Handler->>FS: Write updated tsconfig
FS-->>Handler: Success
else Already acceptable
Handler->>Handler: Skip update
end
else No module config
Handler->>Handler: Skip tsconfig
end
end
Handler-->>CLI: Update complete
CLI-->>Dev: Package generated with<br/>lowercase module values
|
|
The changes in this PR are now available in 3.0.0-canary.13306+cdce5184d |
Tobbe
added a commit
that referenced
this pull request
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The tsconfig json schema currently doesn't support
"module": "Node20", see SchemaStore/schemastore#5326But even if/when that PR gets merged, the intellisense (hover hints/auto complete) will use "node20". And while not 100% consistent, the tsconfig docs also seems to prefer all-lowercase values, listing "node20" as an allowed value

https://www.typescriptlang.org/tsconfig/#module
So this PR switches the "module" value, and a couple of others, to lowercase