Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes ContentFormat modifiable #1

Merged
merged 3 commits into from
Jun 14, 2023
Merged

Conversation

WilliamBruneau
Copy link
Member

@WilliamBruneau WilliamBruneau commented Jun 12, 2023

ContentFormat used to be hardcoded as "RenderedText". This means that all subscriptions retrieved RenderingInfo of all events.

RenderingInfo can be useful for event analysis but it increases event size. It seems necessary to make it configurable.

With this PR, ContentFormat is configurable and can have 2 values: "RenderedText" or "Raw".

See documentation for more details: [MS-WSMV] 3.1.4.1.30.1 Subscription Options :

This option determines how the event data will be received by the event subscriber. If the
value of this option is "RenderedText", both the event data and rendering information are
passed, whereas event data is contained within the element and rendering
info is contained with the element , so that the event can be displayed by
the event subscriber according to a predefined format. The default value for this option is
"Raw", which means that only event data will be passed without any rendering information.

@WilliamBruneau WilliamBruneau force-pushed the renderedtext branch 3 times, most recently from 10d8ba5 to dba531e Compare June 13, 2023 14:44
@vruello vruello merged commit 0666756 into cea-sec:main Jun 14, 2023
bshifter added a commit to bshifter/openwec that referenced this pull request Oct 30, 2024
bshifter added a commit to bshifter/openwec that referenced this pull request Oct 30, 2024
bshifter added a commit to bshifter/openwec that referenced this pull request Oct 30, 2024
bshifter added a commit to bshifter/openwec that referenced this pull request Nov 7, 2024
bshifter added a commit to bshifter/openwec that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants