Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not crash test_all if parametrized is missing #1432

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CLOVIS-AI
Copy link
Contributor

#1422 introduced a thin wrapper around test_all.py used to provide compatibility with unittest and related test frameworks. This approach required the parametrized package, which was added to the optional dependencies. However the test_all.py script always imported this package, which led to crashes when it was not installed.

This PR edits test_all.py so it warns the user of the missing parametrized package and disables the unittest wrapper instead of crashing the script.

A much better implementation of the test framework support is underway in serpilliere#8, but it likely will not reach master for some time yet, so this PR applies a bandaid on master until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant