Update vm_mngr.c #1052
Open
Update vm_mngr.c #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminate compile warnings on MAC. MAC version = 10.12.6 clang version = Apple LLVM version 9.0.0 (clang-900.0.37)
serpilliere
reviewed
Jul 16, 2019
| @@ -926,7 +926,7 @@ void hexdump(char* m, unsigned int l) | |||
| if (!(i%0x10) && i){ | |||
| last = i; | |||
| printf(" "); | |||
| for (j=-0x10;j<0;j++){ | |||
| for (j=-0x10;(int)j<0;j++){ | |||
There was a problem hiding this comment.
Hey @qihuanpiaoliu !
Thank you for the fix.
For the last one, maybe we can declare an "int" (signed) k for example, and use it here to avoid the warning instead of casting j as unsigned. What do you thinl of this?
XVilka
reviewed
Mar 5, 2020
| @@ -226,7 +226,7 @@ static uint64_t memory_page_read(vm_mngr_t* vm_mngr, unsigned int my_size, uint6 | |||
| } | |||
| switch(my_size){ | |||
| case 8: | |||
| ret = ret; | |||
| /*ret = ret*/; | |||
There was a problem hiding this comment.
Should be removed instead of commented I think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate compile warnings on MAC.
MAC version = 10.12.6
clang version = Apple LLVM version 9.0.0 (clang-900.0.37)