Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial support isolated projects #407

Merged
merged 6 commits into from
Aug 31, 2024
Merged

Conversation

cdsap
Copy link
Owner

@cdsap cdsap commented Aug 31, 2024

First part to cover #406, with this PR plugin is not failing with isolated projects affecting the TaskAbbreviationMatcher and the dictionary provided to map tasks and types.

@cdsap cdsap merged commit 5a1fe71 into master Aug 31, 2024
1 check passed
@cdsap cdsap deleted the partial_support_isolated_projects branch August 31, 2024 14:07
cdsap added a commit that referenced this pull request Nov 7, 2024
* partial support isolated projects
@@ -22,3 +22,25 @@ fun String.toBytes(): String? {
}
return null
}

fun String.gradleVersionCompatibleWithIsolatedProjects(): Boolean {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip:

val GradleVersion.isCompatibleWithIsolatedProjects: Boolean =
    GradleVersion.version("8.5") <= this.baseVersion

and

-GradleVersion.current().version.gradleVersionCompatibleWithIsolatedProjects()
+GradleVersion.current().isCompatibleWithIsolatedProjects

Notables:

  • GradleVersion is comparable
  • baseVersion strips the snapshot/rc build part, leaving you with only the "major.minor.patch" part

@cdsap cdsap mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants