Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable file scanning for both Staging and Production environments on GC Forms #872

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

craigzour
Copy link
Contributor

@craigzour craigzour commented Feb 28, 2024

Summary | Résumé

linked to cds-snc/forms-terraform#611

  • Enable file scanning for both Staging and Production environments on GC Forms

@craigzour craigzour self-assigned this Feb 28, 2024
Copy link

Staging: s3_scan_object

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

Plan: 1 to add, 0 to change, 0 to destroy
Show summary
CHANGE NAME
add aws_lambda_event_source_mapping.sqs_s3_events["687401027353"]
Show plan
Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # aws_lambda_event_source_mapping.sqs_s3_events["687401027353"] will be created
  + resource "aws_lambda_event_source_mapping" "sqs_s3_events" {
      + enabled                       = true
      + event_source_arn              = "arn:aws:sqs:ca-central-1:687401027353:s3-scan-object"
      + function_arn                  = (known after apply)
      + function_name                 = "arn:aws:lambda:ca-central-1:127893201980:function:s3-scan-object"
      + id                            = (known after apply)
      + last_modified                 = (known after apply)
      + last_processing_result        = (known after apply)
      + maximum_record_age_in_seconds = (known after apply)
      + maximum_retry_attempts        = (known after apply)
      + parallelization_factor        = (known after apply)
      + state                         = (known after apply)
      + state_transition_reason       = (known after apply)
      + uuid                          = (known after apply)

      + amazon_managed_kafka_event_source_config {
          + consumer_group_id = (known after apply)
        }

      + self_managed_kafka_event_source_config {
          + consumer_group_id = (known after apply)
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"
Show Conftest results
20 tests, 20 passed, 0 warnings, 0 failures, 0 exceptions

@patheard
Copy link
Member

Perfect, thanks for the PR! Let me know once you've merged the s3_scan_object module change to Staging in Forms and we can get this merged.

@craigzour craigzour merged commit 77d38b3 into main Feb 29, 2024
14 checks passed
@craigzour craigzour deleted the feature/enable-file-scanning-for-both-gc-forms-env branch February 29, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants