This repository has been archived by the owner on May 7, 2021. It is now read-only.
Replace kaniko with docker build #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sastels
reviewed
Jun 21, 2019
api/cloudbuild.yaml
Outdated
| @@ -37,12 +37,20 @@ steps: | |||
| - 'MINIO_SECRET_KEY=$_MINIO_SECRET_KEY' | |||
| - 'MINIO_BUCKET_NAME=$_MINIO_BUCKET_NAME' | |||
|
|
|||
| - name: gcr.io/kaniko-project/executor:debug | |||
| - name: 'gcr.io/cloud-builders/docker' | |||
There was a problem hiding this comment.
need the quotes? or is that just Prettier?
There was a problem hiding this comment.
There isn't really a good reason for that. I'll get rid of it.
sastels
approved these changes
Jun 21, 2019
Kaniko builds a bit faster and simplifies cloudbuild config a little by automatically pushing images. Unfortunately it seems to build images that have missing files, which then causes breakage downstream. As an example: GoogleContainerTools/kaniko#362
|
Yeah I ran into similar problems there too and changed it before. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kaniko builds a bit faster and simplifies cloudbuild config a little by
automatically pushing images. Unfortunately it seems to build images that have
missing files, which then causes breakage downstream.
As an example:
GoogleContainerTools/kaniko#362