feat: implement temporary hack to handle Submission lambda name change #3486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Review environmenthttps://7yhladsbslmwc67rbleig7ton40obubr.lambda-url.ca-central-1.on.aws/ |
bryan-robitaille
previously approved these changes
Apr 22, 2024
wmoussa-gc
previously approved these changes
Apr 22, 2024
craigzour
force-pushed
the
feature/backward-compatibility-for-submission-lambda-call
branch
from
489c977
to
8931adf
Compare
craigzour
dismissed stale reviews from wmoussa-gc and bryan-robitaille
via
315ff04
craigzour
force-pushed
the
feature/backward-compatibility-for-submission-lambda-call
branch
from
244005c
to
e51a46a
Compare
craigzour
force-pushed
the
feature/backward-compatibility-for-submission-lambda-call
branch
from
18d0d12
to
2d98b1c
Compare
|
@bryan-robitaille @wmoussa-gc had to implement a fix for a test that was not passing anymore (no idea why it suddenly happened). The issue is that the modal for creating a link in a RichTextBox appears stay up even though we press |
bryan-robitaille
approved these changes
Apr 30, 2024
bryan-robitaille
deleted the
feature/backward-compatibility-for-submission-lambda-call
branch
craigzour
added a commit
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
linked to cds-snc/forms-terraform#626
IMPORTANT:
This should be deployed to Staging and Production "as soon as possible" so that the Lambda containerization update on the infra side can also be released.