Upgrade to python 3.12 #326
Draft
+386
−364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimleroyer
reviewed
Oct 3, 2024
pyproject.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [tool.poetry] | |||
| name = "notifications-utils" | |||
| version = "52.3.3" | |||
| version = "52.3.4" | |||
There was a problem hiding this comment.
We might want to make this a major upgrade as this could break backward compat with other modules.
jimleroyer
reviewed
Oct 3, 2024
| @@ -1,5 +1,5 @@ | |||
| # Container image that runs your code | |||
| FROM ubuntu:22.04@sha256:2b7412e6465c3c7fc5bb21d3e6f1917c167358449fecac8176c6e496e5c1f05f | |||
| FROM python:3.12 | |||
There was a problem hiding this comment.
Hope everything will still run fine with waffles 🤞
There was a problem hiding this comment.
Curious to see as well if renovate will suggest us a proper sha to use in there, for best practices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Upgrade to python 3.12