Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tfsec to 0.39.0 #201

Merged
merged 6 commits into from
Feb 24, 2021
Merged

Bump tfsec to 0.39.0 #201

merged 6 commits into from
Feb 24, 2021

Conversation

AntoineAugusti
Copy link
Contributor

@AntoineAugusti AntoineAugusti commented Feb 24, 2021

Upgrade tfsec and the underlying action. Tackled some new security checks and opened follow-up issues that will take more time or we need guidance from the SRE team.

#203 #202

Did that now because #199 was blocked by tfsec which broke.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@AntoineAugusti AntoineAugusti marked this pull request as ready for review February 24, 2021 15:13
security_group_ids = [
aws_security_group.notification-canada-ca-worker.id
]
subnet_ids = var.vpc_private_subnets
subnet_ids = var.vpc_private_subnets
endpoint_public_access = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@jimleroyer jimleroyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants