Feat/add link checking to gca cypress suite #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add missing routes 2. Add checks for dead links across all pages 3. Refactor the a11y tests a bit to keep code DRY
🧪 Review environmenthttps://p2znnvfv4jgwabdvvcfyi337da0yuwhu.lambda-url.ca-central-1.on.aws/ |
andrewleith
commented
Aug 15, 2023
Comment on lines
+53
to
+73
| for (const viewport of config.viewports) { | ||
| context('A11y and HTML validation test', () => { | ||
| context(`Viewport: ${viewport}px x 660px`, () => { | ||
| for (const lang of langs) { | ||
| const currentLang = (lang === 'en' ? 'English' : 'Francais'); | ||
| context(currentLang, () => { | ||
| for (const page of fullPageList) { | ||
| it(`${page[lang]} passes a11y checks`, () => { | ||
| // cy.viewport(viewport, 660); | ||
| if (lang === 'fr') { | ||
| cy.visit('/set-lang'); | ||
| } | ||
| cy.visit(page[lang]); | ||
|
|
||
| cy.get('main').should('be.visible'); | ||
|
|
||
| // check for a11y compliance | ||
| cy.injectAxe(); | ||
| cy.checkA11y(); | ||
| }); | ||
| } |
There was a problem hiding this comment.
This is just a refactor of the existing a11y test to make it DRY.
andrewleith
commented
Aug 15, 2023
Comment on lines
+40
to
+45
| cy.get('body').within(() => { | ||
| cy.get('a').each((link) => { | ||
| if (link.prop('href').startsWith('mailto') || link.prop('href').startsWith('/set-lang') || link.prop('href').startsWith('#')) return; | ||
| cy.request(link.prop('href')); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
This is the new test that loops through all links on a page (except mailto, language switch, and same-page links)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This PR improves the the cypress GCA test suite by: