feat: vue starter app #21
Conversation
|
There is currently a dependency issue (security vulnerability) with |
| <AppLink :to="getLocalizedPath('about/about1')">{{ t('aboutPage.about1.heading') }}</AppLink> | ||
| </section> | ||
| <section> | ||
| <AppLink :to="getLocalizedPath('about/about2')">{{ t('aboutPage.about2.heading') }}</AppLink> |
There was a problem hiding this comment.
Do you think it might be beneficial to rename these pages to avoid confusion? Initially, I found it a little unclear having 3 pages with almost identical names.
There was a problem hiding this comment.
Yes! Any recommendations? I'm feeling less creative so put these in as a placeholder 👯
There was a problem hiding this comment.
topic-one and topic-two?
| @gcdsValid="handleValid" | ||
| @submit.prevent="handleSubmit" | ||
| > | ||
| <Input |
There was a problem hiding this comment.
Could we add an error summary into this form since it is a bigger form? You could then switch each form component to validate on submit.
| <gcds-header :lang-href="getOtherLangPath" skip-to-href="#main"> | ||
| <gcds-search slot="search"></gcds-search> | ||
| <div slot="toggle"> | ||
| <AppLink :to="getOtherLangPath">{{ t('langToggle') }}</AppLink> |
There was a problem hiding this comment.
Are you able to use the same logic you used for the gcds-nav-link on the gcds-lang-toggle? That way the language toggle will have the proper responsive styling.
Summary | Résumé
Adds a starter app for usage in Vue 3.
This starter app contains the following: