Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set force_destroy to true on Lambda code bucket in preparation for the Lambda containerization upgrade which will delete this bucket #641

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

craigzour
Copy link
Contributor

IMPORTANT:

This should be applied before we merge #626

Summary | Résumé

  • Set force_destroy to true on Lambda code bucket in preparation for the Lambda containerization upgrade which will delete this bucket

… for the Lambda containerization upgrade which will delete this bucket
@craigzour craigzour self-assigned this Apr 30, 2024
Copy link

⚠ Terrform update available

Terraform: 1.8.2 (using 1.6.6)
Terragrunt: 0.57.13 (using 0.54.8)

Copy link

Staging: s3

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

Plan: 0 to add, 1 to change, 0 to destroy
Show summary
CHANGE NAME
update aws_s3_bucket.lambda_code
Show plan
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # aws_s3_bucket.lambda_code will be updated in-place
  ~ resource "aws_s3_bucket" "lambda_code" {
      ~ force_destroy               = false -> true
        id                          = "forms-staging-lambda-code"
        tags                        = {}
        # (10 unchanged attributes hidden)

        # (3 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"
Show Conftest results
WARN - plan.json - main - Missing Common Tags: ["aws_s3_bucket.archive_storage"]
WARN - plan.json - main - Missing Common Tags: ["aws_s3_bucket.audit_logs_archive_storage"]
WARN - plan.json - main - Missing Common Tags: ["aws_s3_bucket.lambda_code"]
WARN - plan.json - main - Missing Common Tags: ["aws_s3_bucket.reliability_file_storage"]
WARN - plan.json - main - Missing Common Tags: ["aws_s3_bucket.vault_file_storage"]

24 tests, 19 passed, 5 warnings, 0 failures, 0 exceptions

@craigzour craigzour merged commit a20e4cb into develop Apr 30, 2024
4 checks passed
@craigzour craigzour deleted the chore/set-force-destroy-on-lambda-code-bucket branch April 30, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants