Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to README file, adjust iterator age alarm threshold and fix to vault data integrity check local lambda test script #525

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

craigzour
Copy link
Contributor

Summary | Résumé

  • Updated README file to reflect changes in Localstack and AWS SAM CLI versions
  • Adjusted threshold for new IteratorAge alarm
  • Fixed issue in payload being passed to the Vault data integrity check lambda when running locally

…ix to vault data integrity check local lambda test script
@craigzour craigzour self-assigned this Oct 31, 2023
Copy link

⚠ Terrform update available

Terraform: 1.6.2 (using 1.4.2)
Terragrunt: 0.53.0 (using 0.46.3)

Copy link

Staging: alarms

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

Plan: 0 to add, 1 to change, 0 to destroy
Show summary
CHANGE NAME
update aws_cloudwatch_metric_alarm.vault_data_integrity_check_lambda_iterator_age
Show plan
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # aws_cloudwatch_metric_alarm.vault_data_integrity_check_lambda_iterator_age will be updated in-place
  ~ resource "aws_cloudwatch_metric_alarm" "vault_data_integrity_check_lambda_iterator_age" {
      ~ alarm_description         = "The Vault data integrity check lambda function is unable to keep up with the amount of events sent by the Vault DynamoDB stream" -> "Warning - Vault data integrity check lambda is unable to keep up with the amount of events sent by the Vault DynamoDB stream"
        id                        = "Vault data integrity check lambda iterator age"
        tags                      = {}
      ~ threshold                 = 30000 -> 90000
        # (16 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Warning: Argument is deprecated

  with module.athena_bucket.aws_s3_bucket.this,
  on .terraform/modules/athena_bucket/S3/main.tf line 8, in resource "aws_s3_bucket" "this":
   8: resource "aws_s3_bucket" "this" {

Use the aws_s3_bucket_logging resource instead

(and 8 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"
Show Conftest results
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_log_group.notify_slack"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.alb_ddos"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.route53_ddos[0]"]
WARN - plan.json - main - Missing Common Tags: ["aws_cloudwatch_metric_alarm.vault_data_integrity_check_lambda_iterator_age"]

21 tests, 17 passed, 4 warnings, 0 failures, 0 exceptions

@craigzour craigzour merged commit 0761ad0 into develop Nov 1, 2023
4 checks passed
@craigzour craigzour deleted the fix/vault-data-integrity-check-fixes branch November 1, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants