Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: temporarily remove additional domain names #519

Merged
merged 11 commits into from
Oct 25, 2023
Merged

fix: temporarily remove additional domain names #519

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ab2fee6
Use new variable for multiple domains
bryan-robitaille Oct 24, 2023
91a0181
test
bryan-robitaille Oct 24, 2023
3eabd2c
test
bryan-robitaille Oct 24, 2023
40f6da0
test
bryan-robitaille Oct 24, 2023
ce0dd48
different approach
bryan-robitaille Oct 24, 2023
56653f1
fix typo in var
bryan-robitaille Oct 24, 2023
982040f
silly mistake, forgot to append local
bryan-robitaille Oct 24, 2023
8e41e8f
update workflows
bryan-robitaille Oct 24, 2023
fe320f7
Merge branch 'develop' into fix/acm_certificate
bryan-robitaille Oct 25, 2023
3452596
remove additional domain names from cert
bryan-robitaille Oct 25, 2023
c666fba
formatting
bryan-robitaille Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions aws/load_balancer/certificates.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
#
resource "aws_acm_certificate" "form_viewer" {
# First entry in domain list is the primary domain
domain_name = var.domains[0]
validation_method = "DNS"
subject_alternative_names = length(var.domains) > 1 ? setsubtract(var.domains, [var.domains[0]]) : []
domain_name = var.domains[0]
validation_method = "DNS"
# subject_alternative_names = length(var.domains) > 1 ? setsubtract(var.domains, [var.domains[0]]) : []

lifecycle {
create_before_destroy = true
Expand Down
Loading