fix: temporarily remove additional domain names

[bryan-robitaille]

Summary | Résumé

In a "what came first... chicken or egg" routine.
This PR disables the adding of additional domain names to the ACM certificate that cannot be verified at this time. Once the canada.ca domain name registration has been completed by 3rd parties we can then uncomment the line to force the recreation of the certificate and enable domain ownership validation.

[github-actions]

⚠ Terrform update available

Terraform: 1.6.2 (using 1.4.2)
Terragrunt: 0.52.5 (using 0.46.3)

[github-actions]

Staging: load_balancer

✅   Terraform Init: success
✅   Terraform Validate: success
✅   Terraform Format: success
✅   Terraform Plan: success
✅   Conftest: success

⚠️   Warning: resources will be destroyed by this change!

Plan: 0 to add, 1 to change, 1 to destroy

Show summary

CHANGE	NAME
delete	aws_acm_certificate.form_viewer
update	aws_lb_listener.form_viewer_https

Show plan

Resource actions are indicated with the following symbols:
  ~ update in-place
  - destroy

Terraform will perform the following actions:

  # aws_acm_certificate.form_viewer (deposed object 72fcd381) will be destroyed
  # (left over from a partially-failed replacement of this instance)
  - resource "aws_acm_certificate" "form_viewer" {
      - arn                       = "arn:aws:acm:ca-central-1:687401027353:certificate/06cc7e5e-6aac-4477-bae5-b0409d6da2f6" -> null
      - domain_name               = "forms-staging.cdssandbox.xyz" -> null
      - domain_validation_options = [
          - {
              - domain_name           = "forms-staging.cdssandbox.xyz"
              - resource_record_name  = "_42cd5dd49f1c1123566280c716149b50.forms-staging.cdssandbox.xyz."
              - resource_record_type  = "CNAME"
              - resource_record_value = "_daaca6a8062fb25ab6d88dcde571d1a3.rlltrpyzyf.acm-validations.aws."
            },
        ] -> null
      - id                        = "arn:aws:acm:ca-central-1:687401027353:certificate/06cc7e5e-6aac-4477-bae5-b0409d6da2f6" -> null
      - status                    = "ISSUED" -> null
      - subject_alternative_names = [] -> null
      - tags                      = {
          - "CostCentre" = "forms-platform-staging"
          - "Terraform"  = "true"
        } -> null
      - tags_all                  = {
          - "CostCentre" = "forms-platform-staging"
          - "Terraform"  = "true"
        } -> null
      - validation_emails         = [] -> null
      - validation_method         = "DNS" -> null

      - options {
          - certificate_transparency_logging_preference = "ENABLED" -> null
        }
    }

  # aws_lb_listener.form_viewer_https will be updated in-place
  ~ resource "aws_lb_listener" "form_viewer_https" {
      ~ certificate_arn   = "arn:aws:acm:ca-central-1:687401027353:certificate/06cc7e5e-6aac-4477-bae5-b0409d6da2f6" -> "arn:aws:acm:ca-central-1:687401027353:certificate/e56dda86-59f7-4c33-b978-8b8bc4768902"
        id                = "arn:aws:elasticloadbalancing:ca-central-1:687401027353:listener/app/form-viewer/5e6bc2d9ab810b68/028e8eeeed9c3a34"
        tags              = {
            "CostCentre" = "forms-platform-staging"
            "Terraform"  = "true"
        }
        # (6 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

Plan: 0 to add, 1 to change, 1 to destroy.

Warning: Argument is deprecated

  with aws_s3_bucket.firehose_waf_logs,
  on kinesis.tf line 30, in resource "aws_s3_bucket" "firehose_waf_logs":
  30: resource "aws_s3_bucket" "firehose_waf_logs" {

Use the aws_s3_bucket_lifecycle_configuration resource instead

(and 5 more similar warnings elsewhere)

─────────────────────────────────────────────────────────────────────────────

Saved the plan to: plan.tfplan

To perform exactly these actions, run the following command to apply:
    terraform apply "plan.tfplan"

Show Conftest results

WARN - plan.json - main - Missing Common Tags: ["aws_wafv2_regex_pattern_set.forms_base_url"]
WARN - plan.json - main - Missing Common Tags: ["aws_wafv2_regex_pattern_set.valid_app_uri_paths"]

19 tests, 17 passed, 2 warnings, 0 failures, 0 exceptions