found a way to keep the old Submission Lambda function name

cds-snc · May 1, 2024 · d20d66b · d20d66b
1 parent cba1c19
commit d20d66b
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 5 deletions.
diff --git a/.github/workflows/request-lambda-functions-to-use-new-image/action.yml b/.github/workflows/request-lambda-functions-to-use-new-image/action.yml
@@ -31,7 +31,9 @@ runs:
         LAMBDA_NAME: ${{ inputs.lambda-name }}
         IMAGE_TAG: ${{ inputs.image-tag }}
         ECR_REGISTRY: ${{ steps.login-ecr-staging.outputs.registry }}
-      run: aws lambda update-function-code --function-name $LAMBDA_NAME --image-uri $ECR_REGISTRY/$LAMBDA_NAME-lambda:$IMAGE_TAG
+      run: |
+        functionName=$([ "$LAMBDA_NAME" == "submission" ] && echo "Submission" || echo "$LAMBDA_NAME")
+        aws lambda update-function-code --function-name $functionName --image-uri $ECR_REGISTRY/$LAMBDA_NAME-lambda:$IMAGE_TAG
       shell: bash
 
     - name: Logout of Staging Amazon ECR

diff --git a/aws/lambdas/submission.tf b/aws/lambdas/submission.tf
@@ -2,8 +2,14 @@
 # Form Submission API processing
 #
 
+/*
+ * For the submission Lambda, when working on https://github.com/cds-snc/forms-terraform/pull/626, we decided to not rename the function name
+ * to avoid any service disruption when releasing to Production. This is due to the web application directly calling the Submission (with a capital S) Lambda.
+ * All the others Lambda functions have lowercase names.
+ */
+
 resource "aws_lambda_function" "submission" {
-  function_name = "submission"
+  function_name = "Submission"
   image_uri     = "${var.ecr_repository_url_submission_lambda}:latest"
   package_type  = "Image"
   role          = aws_iam_role.lambda.arn

diff --git a/env/cloud/pr_review/terragrunt.hcl b/env/cloud/pr_review/terragrunt.hcl
@@ -12,7 +12,7 @@ dependency "lambdas" {
   mock_outputs_merge_with_state           = true
   mock_outputs_merge_strategy_with_state  = "shallow"
   mock_outputs = {
-    lambda_submission_function_name = "submission"
+    lambda_submission_function_name = "Submission"
   }
 }
 

diff --git a/lambda-code/deploy-lambda-images.sh b/lambda-code/deploy-lambda-images.sh
@@ -46,9 +46,11 @@ for lambdaFolderPath in $basedir/*/; do
     docker tag $repositoryName $ecrRepositoryAddress/$repositoryName
     docker push $ecrRepositoryAddress/$repositoryName
 
-    printf "${yellowColor}=> Requesting ${lambdaName} Lambda function to use new image. It can fail if the Lambda function is not deployed yet.${reset}\n"
+    functionName=$([ "$lambdaName" == "submission" ] && echo "Submission" || echo "$lambdaName")
 
-    awslocal lambda update-function-code --function-name $lambdaName --image-uri $ecrRepositoryAddress/$repositoryName > /dev/null || continue
+    printf "${yellowColor}=> Requesting ${functionName} Lambda function to use new image. It can fail if the Lambda function is not deployed yet.${reset}\n"
+
+    awslocal lambda update-function-code --function-name $functionName --image-uri $ecrRepositoryAddress/$repositoryName > /dev/null || continue
   fi
 done