Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new] [author] Add preact w/ npm autoupdate #8391

Merged
merged 4 commits into from
Jun 29, 2016
Merged

[new] [author] Add preact w/ npm autoupdate #8391

merged 4 commits into from
Jun 29, 2016

Conversation

developit
Copy link
Contributor

Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

Essential checklist

  • I'm the author of this library
    • I would like to add link to the page of this library on CDNJS on website / readme
  • This lib was not found on cdnjs repo
  • No already exist / duplicated issue and PR
  • The lib has notable popularity
    • More than 100 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
    • More than 500 downloads stats per month on npm registry
  • Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

  • Has valid tags for each versions (for git auto-update)
  • Auto-update setup
  • Auto-update target/source is valid.
  • Auto-update filemap is correct.

Git commit checklist

  • The first line of commit message is less then 50 chars, be clean and clear, easy to understand.
  • The parent of the commit(s) in the PR is not old than 3 days.
  • Pull request is sending from a non-master branch with meaningful name.
  • Separate unrelated changes into different commits.
  • Use rebase to squash/fixup dummy/unnecessary commits into only one commit. *
  • Close corresponding issue in commit message *
  • Mention related issue(s), people in commit message, comment. *

* I used Github's web interface, since attempting to clone cdnjs in order to make the changes locally took over an hour.

@PeterDaveHello PeterDaveHello changed the title [new] [author] Add preact (fixes cdnjs/cdnjs#8390) [new] [author] Add preact Jun 29, 2016
@PeterDaveHello PeterDaveHello merged commit 8645f69 into cdnjs:master Jun 29, 2016
@PeterDaveHello
Copy link
Contributor

Thanks @developit

@PeterDaveHello PeterDaveHello changed the title [new] [author] Add preact [new] [author] Add preact w/ npm autoupdate Jun 29, 2016
@mohsen1
Copy link

mohsen1 commented Nov 19, 2016

@developit Can you also publish preact-compat please?

@developit
Copy link
Contributor Author

@mohsen1 hmm - might be worth publishing a combined. Preact-compat depends on PropTypes, which is awkward to use from a CDN.

@mohsen1
Copy link

mohsen1 commented Nov 19, 2016

With H/2 it works beautifully. We are requiring super small modules from CDN.

Also a quick question, if we are not using PropTypes (because of TypeScript) can we just avoid including it?

@developit
Copy link
Contributor Author

@mohsen1 I believe so, yes. The checks would never run, so it would just be an unreferenced object. I don't quite remember the process to get a lib added here but I'll look into it when I get a chance.

@mohsen1
Copy link

mohsen1 commented Nov 29, 2016

@developit

I'm not familiar with the process of adding a new lib to CDNjs otherwise I would help. Can you take a look at adding preact compat to CDNjs? It would help our app a lot. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants