Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add KubectlLayer and release as @aws-cdk/lambda-layer-kubectl-v29 #546

Merged
merged 8 commits into from
Feb 9, 2024

Conversation

awsdataarchitect
Copy link
Contributor

@awsdataarchitect awsdataarchitect commented Feb 4, 2024

Fixes #539

@awsdataarchitect
Copy link
Contributor Author

@pahud @kaizencc can you review and approve please. The CDK support for v1.29 is still outstanding

@kaizencc kaizencc changed the base branch from kubectl-v28/main to kubectl-v29/main February 5, 2024 15:59
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awsdataarchitect, I've created the kubectl-v29/main branch for you. I believe you will still need to update the snapshots to get this PR to build: https://github.com/cdklabs/awscdk-asset-kubectl/blob/kubectl-v28/main/CONTRIBUTING.md#contributing-a-new-kubectl-asset

Edit: nevermind i see you already have. but the build is failing for something else

@awsdataarchitect
Copy link
Contributor Author

@kaizencc All tests are passing now. Please approve. Screenshot 2024-02-05 at 6 18 48 PM

@awsdataarchitect awsdataarchitect changed the title feat: add KubectLayer and release as @aws-cdk/lambda-layer-kubectl-v29 feat: add KubectlLayer and release as @aws-cdk/lambda-layer-kubectl-v29 Feb 6, 2024
@awsdataarchitect
Copy link
Contributor Author

Just a small followup @kaizencc @pahud @robertd @udaypant @cgarvis

@robertd
Copy link
Contributor

robertd commented Feb 7, 2024

@kaizencc Can we ship this one?

yarn.lock Show resolved Hide resolved
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good except for the yarn.lock changes. The registry should stay yarnpkg

Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mergify mergify bot merged commit ff2f7cd into cdklabs:kubectl-v29/main Feb 9, 2024
12 checks passed
mergify bot pushed a commit to aws/aws-cdk that referenced this pull request Feb 9, 2024
Similar to #27930, this PR adds eks with k8s 1.29 support.

Addresses #28872 thread. Closes #28983.

### **!! Depends on cdklabs/awscdk-asset-kubectl#546 being merged in first. !!**

/cc @kaizencc @pahud 

### Reason for this change

K8s 1.29 on EKS has been released on 1/23/2024.  See: https://aws.amazon.com/blogs/containers/amazon-eks-now-supports-kubernetes-version-1-29/

### Description of changes

Added support for eks 1.29.

### Description of how you validated changes

Deployed an EKS cluster with k8s 1.29.

![image](https://github.com/aws/aws-cdk/assets/31543/ba770020-2087-498a-a1eb-3e890df05062)

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TheRealAmazonKendra pushed a commit to aws/aws-cdk that referenced this pull request Feb 9, 2024
Similar to #27930, this PR adds eks with k8s 1.29 support.

Addresses #28872 thread. Closes #28983.

### **!! Depends on cdklabs/awscdk-asset-kubectl#546 being merged in first. !!**

/cc @kaizencc @pahud 

### Reason for this change

K8s 1.29 on EKS has been released on 1/23/2024.  See: https://aws.amazon.com/blogs/containers/amazon-eks-now-supports-kubernetes-version-1-29/

### Description of changes

Added support for eks 1.29.

### Description of how you validated changes

Deployed an EKS cluster with k8s 1.29.

![image](https://github.com/aws/aws-cdk/assets/31543/ba770020-2087-498a-a1eb-3e890df05062)

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot pushed a commit that referenced this pull request Jun 5, 2024
…nd remove deprecated python3.7 and nodejs14.x runtimes (#623)

Similar to #546, this PR adds  kubectl 1.29.4 and Helm 3.14.4 security patch 
https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.29.md#changelog-since-v1293
https://github.com/helm/helm/releases/tag/v3.14.4

Fixes [#588](#588). 
Fixes [#752](#752). 

Removes the EOL python3.7 runtime in the integ test and upgrade nodejs14.0 to nodejs16.0 used in custom resource provider by upgrading aws-cdk-lib from 2.28.0 to 2.85.0 in the current branch, which addresses the usage of node 14 [#25995](aws/aws-cdk#25995)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support EKS 1.29
3 participants