Clean up unit tests

cdimascio · Sep 27, 2023 · 01a3502 · 01a3502
1 parent 7250470
commit 01a3502
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 14 deletions.
diff --git a/test/common/app.common.ts b/test/common/app.common.ts
@@ -123,7 +123,6 @@ export function routes(app) {
     res.json({
       ...req.body,
       contentType: req.headers['content-type'],
-      accept: req.headers['accept'],
       id: 'new-id',
     });
   });

diff --git a/test/headers.spec.ts b/test/headers.spec.ts
@@ -71,8 +71,8 @@ describe(packageJson.name, () => {
         })
         .expect(200));
 
-    it('should succeed in sending a content-type: "application/json; version=1"', async () =>
-      request(app)
+    it('should succeed in sending a content-type: "application/json; version=1" in multiple ways', async () =>{
+      await request(app)
         .post(`${app.basePath}/pets_content_types`)
         .set('Content-Type', 'application/json; version=1')
         .set('Accept', 'application/json')
@@ -83,9 +83,22 @@ describe(packageJson.name, () => {
         .expect(200)
         .expect((res) => {
           expect(res.body.contentType).to.equal('application/json; version=1')
-        })
-      );
+        });
 
+      await request(app)
+        .post(`${app.basePath}/pets_content_types`)
+        .set('Content-Type', 'application/json;version=1')
+        .set('Accept', 'application/json')
+        .send({
+          name: 'myPet',
+          tag: 'cat',
+        })
+        .expect(200)
+        .expect((res) => {
+          expect(res.body.contentType).to.equal('application/json;version=1')
+        });
+    });
+
     it('should throw a 415 error for unsupported "application/json; version=2" content type', async () =>
       request(app)
         .post(`${app.basePath}/pets_content_types`)
@@ -97,8 +110,8 @@ describe(packageJson.name, () => {
         })
         .expect(415));
 
-    it('should succeed in sending a content-type: "application/json;version=1', async () =>
-      request(app)
+    it('should throw a 415 error for a path/method which has previously succeeded using different request body content types', async () => {
+      await request(app)
         .post(`${app.basePath}/pets_content_types`)
         .set('Content-Type', 'application/json;version=1')
         .set('Accept', 'application/json')
@@ -109,19 +122,17 @@ describe(packageJson.name, () => {
         .expect(200)
         .expect((res) => {
           expect(res.body.contentType).to.equal('application/json;version=1')
-        })
-      );
-
-    it('should throw a 415 error for a path/method that\'s already been cached', async () =>
-      request(app)
+        });
+
+      await request(app)
         .post(`${app.basePath}/pets_content_types`)
         .set('Content-Type', 'application/json; version=3')
         .set('Accept', 'application/json')
         .send({
           name: 'myPet',
           tag: 'cat',
         })
-        .expect(415));
-
+        .expect(415);
+    });
   });
 });