Include test files so test suite passes from PyPi #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package distributed from PyPi is missing the test data files so the test suite will always fail if the source is fetched from there. The test python files get pulled into the package because they have a .py extension, but the data files the test runs again are missed because they do not. This commit grafts in test/ (pulls in everything) and then excludes pyc, pyo & pyd files per the recommended way of doing this in the python packaging manual.
Merged
cdgriffith
added a commit
that referenced
this pull request
Sep 24, 2021
* Include test files so test suite passes from PyPi (#34) * Install from pypy added to readme (#33) * setup.py cleanup #31 , pre-commit updates, year bump, version bump Co-authored-by: James French <[email protected]> Co-authored-by: Sander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've submitted puremagic to the FreeBSD ports tree - see FreeBSD report https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=258593
While generating the port, I noticed that the package distributed from PyPi is missing the test data files so the test suite will always fail if the source is fetched from there. The python test file (test_common_extensions.py) gets pulled into the python package because it has a .py extension, but the data files the tests run against are missed because they do not.
This commit grafts in test/ (pulls in everything) and then excludes pyc, pyo & pyd files per the recommended way of doing this in the python packaging manual.
FreeBSD preference is to pull all python packages from PyPi and to include test-suites where available. For right now, the options are either omit the test suite or pull from GitHub.