Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hdr-opt to hdr10-opt #89

Closed
SlashX opened this issue Oct 23, 2020 · 3 comments
Closed

hdr-opt to hdr10-opt #89

SlashX opened this issue Oct 23, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@SlashX
Copy link

SlashX commented Oct 23, 2020

Hello again,

I found that in the recent build of x265 and FFmpeg hdr-opt has changed from
--[no-]hdr-opt Add luma and chroma offsets for HDR/WCG content. Default disabled. Now deprecated.
to
--[no-]hdr10-opt Block-level QP optimization for HDR10 content. Default disabled.

When select a HDR10 video, in command line, it shows that is using 'hdr-opt' so it should use the new command 'hdr10-opt'
Screenshot
Fără titlu
@cdgriffith cdgriffith added the bug Something isn't working label Oct 23, 2020
@cdgriffith
Copy link
Owner

Great catch! As x265 seems to ignore "bad" options I will brute-force it for the time being by sending both old and new versions going forward.

cdgriffith added a commit that referenced this issue Oct 23, 2020
@cdgriffith
* Fixing #89 x265 params for hdr10 changed names (thanks to SlashX)
ef23e29
@cdgriffith cdgriffith mentioned this issue Oct 23, 2020
Merged
@SlashX
Copy link
Author

SlashX commented Oct 23, 2020

I just did some research on x265 and I don't think is necessary to send both commands:
For hdr-opt
- [no-] hdr-opt Add Luma and Chroma offsets for HDR / WCG content. Default disabled. Now obsolete.
- [no-] hdr10-opt Block-level QP optimization for HDR10 content. Default disabled.

And for also hdr

  • [no-] hdr Force signalling of HDR parameters in SEI packets. Enabled. Now obsolete.
    -[no-]-hdr10 Force signalling of HDR parameters in SEI packets. Enabled. Default disabled.

The change was made 9 moths ago and ffmpeg 4.3 is using the new commands: here are the commits:
http://hg.videolan.org/x265/rev/3780f7544794
http://hg.videolan.org/x265/rev/fe9d36ccb331

But is your decision, I was thinking of make it less hardcoded and provide you the info on this situation faster.

cdgriffith added a commit that referenced this issue Oct 24, 2020
@cdgriffith
hdr options fix, adding estimations and params (#91)
058a49c 
* Adding ETA and size estimates on status panel
* Adding custom x265-params options
* Changing height to say "Auto" when keeping aspect ratio
* Fixing cover extraction could timeout and crash program
* Fixing #89 x265 params for hdr10 changed names (thanks to SlashX)
* Fixing #92 cannot start FastFlix on Mac (thanks to Paul Bakaus)
@cdgriffith cdgriffith mentioned this issue Oct 24, 2020
Merged
cdgriffith added a commit that referenced this issue Oct 24, 2020
@cdgriffith
hdr options fix, adding estimations and params (#91)
5a64830 
* Adding ETA and size estimates on status panel
* Adding custom x265-params options
* Changing height to say "Auto" when keeping aspect ratio
* Fixing cover extraction could timeout and crash program
* Fixing #89 x265 params for hdr10 changed names (thanks to SlashX)
* Fixing #92 cannot start FastFlix on Mac (thanks to Paul Bakaus)
cdgriffith added a commit that referenced this issue Oct 24, 2020
@cdgriffith
Version 3.3.0 (#93)
780e79a 
* Adding ETA and size estimates on status panel
* Adding custom x265-params options
* Adding support for WebP encodings
* Changing height to say "Auto" when keeping aspect ratio
* Changing that buttons will be disabled without video or when encoding
* Fixing cover extraction could timeout and crash program
* Fixing #89 x265 params for hdr10 changed names (thanks to SlashX)
* Fixing #92 cannot start FastFlix on Mac (thanks to Paul Bakaus)
* Fixing autocrop sometimes failing due to muxing size limitations
* Fixing thumbnail generation did not work for videos with multiple video tracks
* Fixing gif generation to work with new filter_complex
* Fixing gif output network location would not work
@cdgriffith
Copy link
Owner

3.3.0 now has both so it will work with both newer and older ffmpeg compiles. For a nice feature would be good to have another panel with a lot of x265 specific params including those options, but that is more far off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SlashX @cdgriffith