Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not download FFmpeg #76

Closed
sioc-de-narf opened this issue Oct 4, 2020 · 5 comments
Closed

Could not download FFmpeg #76

sioc-de-narf opened this issue Oct 4, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@sioc-de-narf
Copy link

Hi, i tried both FastFlix_3.0.0_installer.exe and FastFlix_3.0.0_win64.zip and with both i got :

C:\Program Files\FastFlix>FastFlix.exe
2020-10-04 19:19:24 DESKTOP-2OIM4BI fastflix-core[3416] INFO Starting FastFlix 3.0.0
2020-10-04 19:19:25 DESKTOP-2OIM4BI fastflix[14352] DEBUG Using qt engine pyqt5 version 5.15.1
2020-10-04 19:19:25 DESKTOP-2OIM4BI fastflix[14352] DEBUG Using config file "C:\Users\sioc\AppData\Roaming\FastFlix\fastflix.json"
Downloaded 0MB
2020-10-04 19:19:28 DESKTOP-2OIM4BI fastflix[14352] ERROR Could not download FFmpeg
Traceback (most recent call last):
File "fastflix\gui.py", line 214, in required_info
File "fastflix\gui.py", line 295, in windows_download_ffmpeg
File "reusables\file_operations.py", line 80, in extract
TypeError: File is not a known archive
2020-10-04 19:19:28 DESKTOP-2OIM4BI fastflix[14352] ERROR HARD FAIL: Unexpected error: 2
Traceback (most recent call last):
File "fastflix\gui.py", line 214, in required_info
File "fastflix\gui.py", line 295, in windows_download_ffmpeg
File "reusables\file_operations.py", line 80, in extract
TypeError: File is not a known archive

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "fastflix\gui.py", line 263, in start_app
File "fastflix\gui.py", line 217, in required_info
SystemExit: 2
Unexpected error: 2

@cdgriffith cdgriffith added the bug Something isn't working label Oct 4, 2020
@cdgriffith
Copy link
Owner

cdgriffith commented Oct 5, 2020

I apologize I didn't have a chance to respond yet today, thank you for raising the issue!

As a backup until I look at and fix it you can always download FFmpeg manually: https://www.gyan.dev/ffmpeg/builds/ffmpeg-release-full.7z

Then you will have to update the config file (fastflix.json on your system at C:\Users\sioc\AppData\Roaming\FastFlix\fastflix.json) to manually point to them. For example if you created a folder in your user directory called FFmpeg and put the binaries (ffmpeg.exe and ffprobe.exe) from inside the downloaded zip file directly in that folder, the updated config would have these fields:

  "work_dir": "C:\\Users\\sioc\\AppData\\Roaming\\FastFlix",
  "ffmpeg": "C:\\Users\\sioc\\FFmpeg\\ffmpeg.exe",
  "ffprobe": "C:\\Users\\sioc\\FFmpeg\\ffprobe.exe",

@cdgriffith
Copy link
Owner

The issue it seems it that gyan.dev has updated the name and packaging of FFmpeg to be 7z archives.

The "proper" solution is to build FFmpeg myself and bundle it with FFmpeg for windows systems. There are a lot of logistic, server time and legal waters to navigate to do that correctly is why I have been avoiding it. (FFmpeg themselves don't offer builds directly to avoid those issues, and that's why they link to third parties such as gyan.dev on their official website.)

cdgriffith added a commit that referenced this issue Oct 5, 2020
…thub.com/BtbN/FFmpeg-Builds/releases (thanks to sioc)

* Fixing failure size calculation limit on file to 500 bytes due to VP9
@cdgriffith cdgriffith mentioned this issue Oct 5, 2020
cdgriffith added a commit that referenced this issue Oct 5, 2020
* Fixing #76 Windows FFmpeg builds switch from gyan.dev to https://github.com/BtbN/FFmpeg-Builds/releases (thanks to sioc)
* Fixing failure size calculation limit on file to 500 bytes due to VP9
@cdgriffith
Copy link
Owner

Fixed in https://github.com/cdgriffith/FastFlix/releases/tag/3.0.2

Thanks for bringing this to my attention!

@mediamanrit
Copy link

It appears this is broken again in 3.1.0 .

@cdgriffith cdgriffith reopened this Oct 22, 2020
@cdgriffith
Copy link
Owner

Fixed betterer (I hope) in 3.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants