-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDR2SDR double tonemapping in Rigaya NVENC and QSV Encoders #605
Comments
Hello @Darksyderz can you please use online example files such as https://github.com/cdgriffith/FastFlix/blob/master/tests/media/Beverly%20Hills%20Duck%20Pond%20-%20HDR10plus%20-%20Jessica%20Payne.mp4 to test with. Or from https://4kmedia.org/ Making sure I understand, the issue is happening on in both Rigaya's encoders but not ffmpeg's built in nvenc one? |
Acutally found out where the error in code this is happening. Will fix, thanks for raising the issue! |
wow thank you for the super quick response <3 much love and appreciation for all the work you do my friend. |
* Fixing #598 'dict' object has no attribute 'to_yaml' (thanks to dmo marillat) * Fixing #599 Italian language translations (thanks to bovirus) * Fixing #600 Update NSIS installer script #601 to include Italian (thanks to bovirus) * Fixing #603 Themes stylesheet aren't included in python package (thanks to dmo marillat) * Fixing #605 HDR2SDR double tonemapping in Rigaya NVENC and QSV Encoders (thanks to Darksyderz) --------- Co-authored-by: bovirus <[email protected]> Co-authored-by: dmo <[email protected]>
Hello <3 huge lover of fastflix, found this after trying handbrake and found it much easier for most things. been having issues with HDR2SDR tonemapping though, specifically with the Rigaya set of encoders. i usually use reinhard TMPing due to its overall look. when using the rigaya encoders either compiled from source or precompiled. i seem to have a double tonemapping issue causing the end footage to be absolutely garbled. enclosed below are the commands it outputs that are problematic as well as screenshots showing the non default nvenc encoder, qsv encoder and the default nvenc option with HDR removal and reinhard tonemapping shown. any help would definitely be appreciated as Rs encoders do a faster job overall with more control.
The text was updated successfully, but these errors were encountered: