Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Actions on Completion #57

Closed
TGMais opened this issue Sep 5, 2020 · 4 comments
Closed

Feature Request: Actions on Completion #57

TGMais opened this issue Sep 5, 2020 · 4 comments
Labels
feature request New idea for project

Comments

@TGMais
Copy link
Contributor

TGMais commented Sep 5, 2020

Not sure if this is reasonable with the current command line setup, but it would be nice to be able to tell the computer to shutdown or run some other commands when complete.

@cdgriffith cdgriffith added the feature request New idea for project label Sep 8, 2020
@cdgriffith
Copy link
Owner

This could actually be expanded into its own tab and just have "Actions" for "pre" and "post" conversion.

Then can have a way to use common ones or save your own to the config file as well.

@cdgriffith
Copy link
Owner

cdgriffith commented Sep 30, 2020

I am working on adding this for next release. Currently I don't think a whole tab for it makes sense, so have reduced it to a drop down. However, I also am adding the idea of custom commands that can be configured via the config file.

For example:

  "custom_after_run_scripts": {"test": "echo 'test'"}

It's added to the command tab in the UI:

command to run

Edit: I should note, that the run level user will need permissions to perform whatever actions are to take place. Otherwise they will fail without asking for escalation.

cdgriffith added a commit that referenced this issue Oct 18, 2020
* Adding support for movie title
* Adding settings for disable update check on startup and limited audio conversions
* Adding #57 after conversion options (thanks to TGMais)
* Adding Windows should not to go to sleep during conversion
* Changing #80 thumbnail preview will start at 10% in if no start time given (thanks to zsumie)
* Changing no longer need to restart for setting page changes
* Changing width and height will only give warnings if not divisible by two
* Fixing output name is not regenerated on encoder switch if matching extension
* Fixing #79 crash on no internet connection (thanks to L0Lock)
* Fixing output paths not working on network drives
@cdgriffith
Copy link
Owner

The initial version of this is out in https://github.com/cdgriffith/FastFlix/releases/tag/3.1.0. I do not know if permissions for the running user will always be appropriate to complete said command actions, so I would consider this "experimental" for now.

I an not planning closing this ticeket until I add documentation on how to add custom commands via the config file.

@cdgriffith
Copy link
Owner

Basic guide added to the wiki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New idea for project
Projects
None yet
Development

No branches or pull requests

2 participants