Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio Selection #322

Closed
wynterca opened this issue Apr 7, 2022 · 1 comment
Closed

Audio Selection #322

wynterca opened this issue Apr 7, 2022 · 1 comment
Labels
feature request New idea for project

Comments

@wynterca
Copy link

wynterca commented Apr 7, 2022

Would it be possible to add a warning if adding a job to the Encoding Queue that would warn if there is no audio track selected? For example I have a profile that adds the first english track but sometimes I find a file that doesn't have a language set for the track and therefore no track is selected. Or possibly for the profile selection that if there is not matching language to add the first track?
@cdgriffith cdgriffith added the feature request New idea for project label Apr 14, 2022
cdgriffith added a commit that referenced this issue Jul 20, 2022
@cdgriffith
* Adding #322 warning if profile audio match doesn't match anything (…
7237194 
…thanks to wynterca)

* Fixing #319 no longer disables built in tracks for profile matching (thanks to Owen Quinlan)
* Fixing #218 and #308 subtitle scaling with rigaya's hardware encoders needs to be scaled for 4K content (thanks to wynterca)
@cdgriffith cdgriffith mentioned this issue Jul 20, 2022
Merged
cdgriffith added a commit that referenced this issue Jul 21, 2022
@cdgriffith @leonardyan
Version 4.10.0 (#360)
ec54941 
* Adding AVIF support using libsvtav1
* Adding #352 default output directory to settings panel (thanks to Maddie Davis)
* Adding #306 support for audio profiles with pattern matching for rigaya's hardware encoders
* Adding #301 Select All feature for subtitles (thanks to ProFire and Genine-Collin)
* Adding #325 build for Ubuntu 22.04 (thanks to mrjayviper)
* Adding build for MacOS 12
* Adding #322 warning if profile audio match doesn't match anything (thanks to wynterca)
* Adding presumption that 4.x branch is last to support Windows 7 and 8 for update checks
* Fixing #319 no longer disables built in tracks for profile matching (thanks to Owen Quinlan)
* Fixing #218 and #308 subtitle scaling with rigaya's hardware encoders needs to be scaled for 4K content (thanks to wynterca)
* Fixing #350 subtitle burn in quoting (thanks to Maddie Davis)
* Fixing #346 preserve the order of audio tracks when editing a queued job (thanks to Patrick Bassner)
* Fixing #187 closing the main app while a progress bar is active will now stop that task (thanks to Todd Wilkinson)
* Fixing Chinese translations (thanks to leonardyan)
* Fixing new version check not launching at startup

Co-authored-by: leonardyan <[email protected]>
@cdgriffith
Copy link
Owner

Great idea! I have added a warning popup if your profile doesn't select an audio track in 4.10.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New idea for project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdgriffith @wynterca