* Fixing $578 Missing code signing to FastFlix exec inside of the ins…

…taller (thanks to Sam Katakouzinos)

* Fixing #580 No Downmix key error on profile save (thanks to Hankuu)
* Fixing #581 Fastflix could not recognize hevc video containing hdr10plus metadata with recent ffmpeg build (thanks to alpha-0)

.github/workflows/build.yaml

@@ -107,6 +107,16 @@ jobs:
       shell: cmd
       run: pyinstaller FastFlix_Windows_Installer.spec
 
+    - uses: skymatic/code-sign-action@v1
+      with:
+        certificate: '${{ secrets.CODE_CERT_B64 }}'
+        password: '${{ secrets.CODE_CERT_PASS }}'
+        certificatesha1: '${{ secrets.CODE_CERT_THUMB }}'
+        description: 'FastFlix'
+        timestampUrl: 'http://timestamp.sectigo.com'
+        folder: 'dist\FastFlix'
+        recursive: false
+
     - name: Package installer
       shell: cmd
       run: |

CHANGES

@@ -1,5 +1,11 @@
 # Changelog
 
+## Version 5.7.4
+
+* Fixing $578 Missing code signing to FastFlix exec inside of the installer (thanks to Sam Katakouzinos)
+* Fixing #580 No Downmix key error on profile save (thanks to Hankuu)
+* Fixing #581 Fastflix could not recognize hevc video containing hdr10plus metadata with recent ffmpeg build (thanks to alpha-0)
+
 ## Version 5.7.3
 
 * Fixing #574 Downmix audio channels not working (thanks to eikixsh)

fastflix/encoders/common/audio.py

@@ -64,15 +64,16 @@ def build_audio(audio_tracks, audio_file_index=0):
             command_list.append(f"-c:{track.outdex} copy")
         elif track.conversion_codec:
             try:
-                cl = track.downmix if track.downmix else track.raw_info.channel_layout
-            except AssertionError:
+                cl = track.downmix if track.downmix and track.downmix != "No Downmix" else track.raw_info.channel_layout
+            except (AssertionError, KeyError):
                 cl = "stereo"
+
             downmix = (
                 f"-ac:{track.outdex} {channel_list[cl]} -filter:{track.outdex} aformat=channel_layouts={cl}"
-                if track.downmix
+                if track.downmix and track.downmix != "No Downmix"
                 else ""
             )
-            channel_layout = f'-filter:{track.outdex} aformat=channel_layouts="{track.raw_info.channel_layout}"'
+            channel_layout = f'-filter:{track.outdex} aformat=channel_layouts="{channel_list[cl]}"'
 
             bitrate = ""
             if track.conversion_codec not in lossless:

fastflix/encoders/common/encc_helpers.py

@@ -117,7 +117,9 @@ def build_audio(audio_tracks: list[AudioTrack], audio_streams):
         if not track.conversion_codec or track.conversion_codec == "none":
             copies.append(str(audio_id))
         elif track.conversion_codec:
-            downmix = f"--audio-stream {audio_id}?:{track.downmix}" if track.downmix else ""
+            downmix = (
+                f"--audio-stream {audio_id}?:{track.downmix}" if track.downmix and track.downmix != "No Downmix" else ""
+            )
             bitrate = ""
             if track.conversion_codec not in lossless:
                 if track.conversion_bitrate:

fastflix/flix.py

@@ -603,7 +603,7 @@ def detect_hdr10_plus(app: FastFlixApp, config: Config, **_):
                 "panic",
                 "-c:v",
                 "copy",
-                "-vbsf",
+                "-bsf:v",
                 "hevc_mp4toannexb",
                 "-f",
                 "hevc",

fastflix/version.py

@@ -1,4 +1,4 @@
 #!/usr/bin/env python
 # -*- coding: utf-8 -*-
-__version__ = "5.7.3"
+__version__ = "5.7.4"
 __author__ = "Chris Griffith"

fastflix/widgets/background_tasks.py

@@ -129,7 +129,7 @@ def run(self):
             f"0:{track}",
             "-c:v",
             "copy",
-            "-vbsf",
+            "-bsf:v",
             "hevc_mp4toannexb",
             "-f",
             "hevc",

fastflix/widgets/windows/hdr10plus_inject.py

@@ -135,7 +135,7 @@ def prep_command(self):
 
         command = (
             f'{self.app.fastflix.config.ffmpeg} -loglevel panic -i "{self.movie_file.text()}" '
-            f'-map 0:{self.selected_stream["index"]} -c:v copy -vbsf hevc_mp4toannexb -f hevc - | '
+            f'-map 0:{self.selected_stream["index"]} -c:v copy -bsf:v hevc_mp4toannexb -f hevc - | '
             f"{self.app.fastflix.config.hdr10plus_parser} inject -i - -j {self.hdr10p_file.text()} -o - | "
             f'{self.app.fastflix.config.ffmpeg} -loglevel panic -i - -i {self.movie_file.text()} -map 0:0 -c:0 copy -map 1:a -map 1:s -map 1:d -c:1 copy "{self.output_file.text()}"'
         )

fastflix/widgets/windows/profile_window.py

@@ -154,7 +154,7 @@ def get_settings(self):
             match_input=match_input_value,
             conversion=self.convert_to.currentText() if self.convert_to.currentIndex() > 0 else None,
             bitrate=self.bitrate.currentText(),
-            downmix=self.downmix.currentText(),
+            downmix=self.downmix.currentText() if self.downmix.currentIndex() > 0 else None,
         )