Skip to content

Commit

Permalink
Version 2.3.4 (#48)
Browse files Browse the repository at this point in the history
* Fixing audio downmixing only taking last downmixing setting
  • Loading branch information
cdgriffith authored Aug 23, 2020
1 parent a4b93bd commit 7631a34
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 7 deletions.
5 changes: 5 additions & 0 deletions CHANGES
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
Changelog
---------

Version 2.3.4
~~~~~~~~~~~~~

* Fixing audio downmixing only taking for last downmixing setting

Version 2.3.3
~~~~~~~~~~~~~

Expand Down
3 changes: 1 addition & 2 deletions fastflix/plugins/common/audio.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,13 @@
def build_audio(audio_tracks, audio_file_index=0):
command_list = []
for track in audio_tracks:
downmix = f"-ac {track.downmix}" if track.downmix > 0 else ""
downmix = f"-ac:{track.outdex} {track.downmix}" if track.downmix > 0 else ""
command_list.append(
f"-map {audio_file_index}:{track.index} "
f'-metadata:s:{track.outdex} title="{track.title}" '
f'-metadata:s:{track.outdex} handler="{track.title}"'
)
if track.conversion.codec == "none":
# command_list.append(f"-c:a:{track.outdex-1} copy")
command_list.append(f"-c:{track.outdex} copy")
elif "conversion" in track:
command_list.append(
Expand Down
2 changes: 1 addition & 1 deletion fastflix/version.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/usr/bin/env python
# -*- coding: utf-8 -*-
__version__ = "2.3.3"
__version__ = "2.3.4"
__author__ = "Chris Griffith"
3 changes: 0 additions & 3 deletions fastflix/widgets/about.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@


class About(QtWidgets.QWidget):

# TODO add all licenses

def __init__(self, parent=None):
super(About, self).__init__(parent)
layout = QtWidgets.QGridLayout()
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "fastflix"
version = "2.3.3"
version = "2.3.4"
description = "Easy to use video encoder GUI wrapper"
authors = ["Chris Griffith <[email protected]>"]
license = "MIT"
Expand Down

0 comments on commit 7631a34

Please sign in to comment.