* Fixing too long of log file names could crash (thanks to ProFile)

* Removing code signing as cert has expired
cdgriffith · Nov 20, 2024 · 0515b04 · 0515b04
1 parent 8439ef5
commit 0515b04
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 19 deletions.
diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
@@ -124,31 +124,31 @@ jobs:
       shell: cmd
       run: pyinstaller FastFlix_Windows_Installer.spec
 
-    - uses: skymatic/code-sign-action@v1
-      with:
-        certificate: '${{ secrets.CODE_CERT_B64 }}'
-        password: '${{ secrets.CODE_CERT_PASS }}'
-        certificatesha1: '${{ secrets.CODE_CERT_THUMB }}'
-        description: 'FastFlix'
-        timestampUrl: 'http://timestamp.sectigo.com'
-        folder: 'dist\FastFlix'
-        recursive: false
+#    - uses: skymatic/code-sign-action@v1
+#      with:
+#        certificate: '${{ secrets.CODE_CERT_B64 }}'
+#        password: '${{ secrets.CODE_CERT_PASS }}'
+#        certificatesha1: '${{ secrets.CODE_CERT_THUMB }}'
+#        description: 'FastFlix'
+#        timestampUrl: 'http://timestamp.sectigo.com'
+#        folder: 'dist\FastFlix'
+#        recursive: false
 
     - name: Package installer
       shell: cmd
       run: |
         makensis.exe /INPUTCHARSET UTF8 /DVERSION=${{ env.EXACT_VERSION }} /DPRODUCT_VERSION=${{ env.PRODUCT_VERSION }} FastFlix.nsi
         move FastFlix_installer.exe dist\FastFlix_${{ env.VERSION }}_installer.exe
 
-    - uses: skymatic/code-sign-action@v1
-      with:
-        certificate: '${{ secrets.CODE_CERT_B64 }}'
-        password: '${{ secrets.CODE_CERT_PASS }}'
-        certificatesha1: '${{ secrets.CODE_CERT_THUMB }}'
-        description: 'FastFlix'
-        timestampUrl: 'http://timestamp.sectigo.com'
-        folder: 'dist'
-        recursive: false
+#    - uses: skymatic/code-sign-action@v1
+#      with:
+#        certificate: '${{ secrets.CODE_CERT_B64 }}'
+#        password: '${{ secrets.CODE_CERT_PASS }}'
+#        certificatesha1: '${{ secrets.CODE_CERT_THUMB }}'
+#        description: 'FastFlix'
+#        timestampUrl: 'http://timestamp.sectigo.com'
+#        folder: 'dist'
+#        recursive: false
 
     - name: Test executable
       run: |

diff --git a/CHANGES b/CHANGES
@@ -4,6 +4,8 @@
 
 * Fixing #610 Do not try to divide by zero if HDR metadata has bad values (thanks to Noelle Leigh)
 * Fixing #616 replace correct cmd line option for IDC level (thanks to pkleinejaeger)
+* Fixing too long of log file names could crash (thanks to ProFile)
+* Removing code signing as cert has expired
 
 ## Version 5.8.1
 

diff --git a/fastflix/conversion_worker.py b/fastflix/conversion_worker.py
@@ -39,7 +39,7 @@ def start_command():
         log_queue.put(f"CLEAR_WINDOW:{video_uuid}:{command_uuid}")
         reusables.remove_file_handlers(logger)
         new_file_handler = reusables.get_file_handler(
-            log_path / sanitize_filename(f"flix_conversion_{log_name}_{file_date()}.log"),
+            log_path / sanitize_filename(f"flix_conversion_{log_name[:64]}_{file_date()}.log"),
             level=logging.DEBUG,
             log_format="%(asctime)s - %(message)s",
             encoding="utf-8",