Update service environment to be a ref #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The service environment is a ref to an environment in the schemas and it should be a ref, i.e. a combination of id and source because the id is only unique when combined to the source. As in other cases, if the source of the environment is the same as the source of the main subject (the service), it may be omitted. The spec only includes today the environmentId as string - update it to be an object (reference to environment). Signed-off-by: Andrea Frittoli <[email protected]>
e-backmark-ericsson
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The service environment is a ref to an environment in the schemas and it should be a ref, i.e. a combination of id and source because the id is only unique when combined to the source.
As in other cases, if the source of the environment is the same as the source of the main subject (the service), it may be omitted.
The spec only includes today the environmentId as string - update it to be an object (reference to environment).
Signed-off-by: Andrea Frittoli [email protected]
Submitter Checklist
As the author of this PR, please check off the items in this checklist: