Add service published event to the spec #31
Conversation
This is WRT the issue cdfoundation/sig-events#111 Also fix a typo
| - __Service Rolledback__: an existing instance of a Service has been rolledback to a previous version | ||
| - __Service Removed__: an existing instance of a Service has been terminated an it is not longer present in an environment | ||
| - __Service Removed__: an existing instance of a Service has been terminated an it is no longer present in an environment | ||
| - __Service Published__: an existing instance of a Service has an accessible URL for users to interact with it. This event can be used to let other tools know that the service is ready but also available for consumption. |
There was a problem hiding this comment.
Could we introduce some description on how this event relates to Service Deployed? For a new reader, reading the spec for the first time it might be hard to understand when you should use Deployed vs Published
There was a problem hiding this comment.
sure @m-linner-ericsson , I think the idea was to be able to distinguish between scenarios like a Service created but isn't yet exposed/ready for consumption because the external IP from LB is not yet assigned. In such a scenario one would use a Service Deployed event and once the IP gets assigned and hence its ready for consumption by clients, we can use the Service Published event. If this sounds good then I can add these details to the above section. Let me know your view on this.
There was a problem hiding this comment.
I think it sounds good. I'm not sure all systems will have that granularity, so we could recommend which of the two events to send when unsure, but we can also follow-up on this.
@m-linner-ericsson wdyt?
There was a problem hiding this comment.
Sorry for missing the comment. Just so we have some text. But please insert the one you wrote 😄
|
Hello @ishankhare07 - are you still working on this? |
|
Hey @afrittoli , just left a response to the feedback comment. We can discuss over it and if it seems good I'll add the details to the relevant sections. |
add distinction for when to use Deployed vs Published events
|
Hey @afrittoli @m-linner-ericsson made the necessary changes to the spec. |
|
@afrittoli @m-linner-ericsson can we merge this one? or do we need more details? |
4 participants
This is WRT the issue cdfoundation/sig-events#111
Also fix a typo