Skip to content

Conversation

afrittoli
Copy link
Contributor

@afrittoli afrittoli commented Apr 5, 2024

Changes

Update all events, close -draft versions:

  • ls examples | while read aa; do sp="$(echo ${aa%.*} | tr "_" ".")"; ./tools/event-version.sh -u $sp -e; done

Update the spec script to handle the custom events schema. Update the spec:

  • ./tools/spec-release.sh -e

Remove a couple of references to "-draft" versions from the links.md document.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Update all events, close -draft versions:
- ls examples | while read aa; do sp="$(echo ${aa%.*} | tr "_" ".")"; ./tools/event-version.sh -u $sp -e; done

Update the spec script to handle the custom events schema.
Update the spec:
- ./tools/spec-release.sh -e

Remove a couple of references to "-draft" versions from the
links.md document.

Signed-off-by: Andrea Frittoli <[email protected]>
@afrittoli afrittoli requested a review from a team as a code owner April 5, 2024 11:31
Copy link
Contributor

@e-backmark-ericsson e-backmark-ericsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't verified that no '-draft' versions still exists, but what is there looks good at least :)
I propose that this PR is not merged until all issues in the v0.4 milestone has been cleared/completed though.

@afrittoli
Copy link
Contributor Author

I haven't verified that no '-draft' versions still exists, but what is there looks good at least :) I propose that this PR is not merged until all issues in the v0.4 milestone has been cleared/completed though.

Thanks @e-backmark-ericsson - I did a blanket search for -draft - so it's hopefully ok.
We can review the milestone on Monday and merge the PR once it's approved.

Copy link
Contributor

@xibz xibz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

pulled down PR, and saw that there were no "-draft". We should be good 👍

@afrittoli afrittoli merged commit b462f84 into cdevents:main Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants