Prepare for release v0.2.0 #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release incident events to 0.1.0. Release the spec to 0.2.0. Update schemas, examples and markdown to the new versions. Extend the release script to handle example files too. Signed-off-by: Andrea Frittoli <[email protected]>
afrittoli
force-pushed
the
release_0_2_prep
branch
from
c5bedca to
fe47609
Compare
Signed-off-by: Andrea Frittoli <[email protected]>
elmsdata
reviewed
Mar 17, 2023
|
|
||
| # Evaluate the event version | ||
| OLD_VERSION=$(sed -n -e '/"default": "dev.cdevents.'${SUBJECT}'.'${PREDICATE}'./s/.*\.\([0-9]\.[0-9]\.[0-9]\)"/\1/p' ${SCHEMA_FILE}) | ||
| OLD_VERSION=$(sed -n -e '/"default": "dev.cdevents.'${SUBJECT}'.'${PREDICATE}'./s/.*\.\([0-9]\.[0-9]\.[0-9]\(-draft\)\{0,1\}\)"/\1/p' ${SCHEMA_FILE}) |
There was a problem hiding this comment.
Still learning about release cadence and pattern for the project so my understanding is likely wrong, if you are removing the reference -draft from schemas then should it be included in the regex?
There was a problem hiding this comment.
Thanks for the review!
The regex allows for the -draft to both be and not be there.
When we start working on a new release, we set it with the -draft, when we cut a release, we remove it.
See https://cdevents.dev/docs/primer/#development-of-a-new-version
This script is a helper to start and finish releases, and it must be able to parse the current version in both cases.
e-backmark-ericsson
approved these changes
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Release incident events to 0.1.0.
Release the spec to 0.2.0.
Update schemas, examples and markdown to the new versions.
Extend the release script to handle example files too.
Submitter Checklist
As the author of this PR, please check off the items in this checklist: