Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CDAP-21027 : upgrading hadoop version to 3.3.6 #15648
CDAP-21027 : upgrading hadoop version to 3.3.6 #15648
Changes from all commits
5b75e69
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 138 in cdap-app-fabric-tests/src/test/java/io/cdap/cdap/internal/app/runtime/batch/DynamicPartitionerWithAvroTest.java
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment here explaining why this property is set. We also need to document this in case a customer needs to overwrite this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Regarding documentation, I can add to release notes, but this change is only applicable to map reduce programs, which is already deprecated. I don't think we use map reduce outside of tests anymore.
For spark, we already support custom arguments
Check warning on line 44 in cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/batch/dataset/partitioned/DynamicPartitioningOutputCommitter.java
com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck
Check warning on line 75 in cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/batch/dataset/partitioned/DynamicPartitioningOutputCommitter.java
com.puppycrawl.tools.checkstyle.checks.javadoc.MissingJavadocMethodCheck
Check warning on line 81 in cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/batch/dataset/partitioned/DynamicPartitioningOutputCommitter.java
com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck
Check warning on line 82 in cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/batch/dataset/partitioned/DynamicPartitioningOutputCommitter.java
com.puppycrawl.tools.checkstyle.checks.whitespace.OperatorWrapCheck
Check warning on line 83 in cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/batch/dataset/partitioned/DynamicPartitioningOutputCommitter.java
com.puppycrawl.tools.checkstyle.checks.whitespace.OperatorWrapCheck
Check warning on line 326 in cdap-app-fabric/src/main/java/io/cdap/cdap/internal/app/runtime/batch/dataset/partitioned/DynamicPartitioningOutputCommitter.java
com.puppycrawl.tools.checkstyle.checks.javadoc.SummaryJavadocCheck
Check warning on line 84 in cdap-app-fabric/src/test/java/io/cdap/cdap/internal/capability/AutoInstallTest.java
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck