Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸🚨 Eliminate reference members and improve TaskManager interface #349

Merged
merged 4 commits into from
Jan 5, 2024

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Jan 5, 2024

Description

This was triggered by a clang-tidy warning that popped up in #348.
This PR also adjusts the TaskManager interface to take a reference to a package instance instead of a unique pointer; making the interface more generic.
This should unblock #348.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code c++ Anything related to C++ code code quality Anything related to code quality and code style. labels Jan 5, 2024
@burgholzer burgholzer self-assigned this Jan 5, 2024
@burgholzer burgholzer mentioned this pull request Jan 5, 2024
4 tasks
burgholzer added a commit that referenced this pull request Jan 5, 2024
## Description

This PR was triggered by the failures in #349 and its purpose is to
better isolate the changes into separate PRs.
- cda-tum/mqt-core#515

has dropped the submodules in `mqt-core` and replaced them with
`FetchContent`. As such, the `googletest` test dependency is no longer
available at its typical location.
Consequently, this PR now also uses `FetchContent` to get `googletest`.
In a future PR, this will most likely be extended to the `mqt-core`
submodule as well.

This should unblock #349.

## Checklist:

<!---
This checklist serves as a reminder of a couple of things that ensure
your pull request will be merged swiftly.
-->

- [x] The pull request only contains commits that are related to it.
- [x] I have added appropriate tests and documentation.
- [x] I have made sure that all CI jobs on GitHub pass.
- [x] The pull request introduces no new warnings and follows the
project's style guidelines.

---------

Signed-off-by: burgholzer <[email protected]>
@burgholzer burgholzer changed the title 🚸🚨 Eliminate reference members and update mqt-core 🚸🚨 Eliminate reference members and improve TaskManager interface Jan 5, 2024
@burgholzer burgholzer enabled auto-merge (squash) January 5, 2024 14:14
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1ab1ffa) 96.2% compared to head (b112d72) 96.3%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #349   +/-   ##
=====================================
  Coverage   96.2%   96.3%           
=====================================
  Files         34      34           
  Lines       1749    1751    +2     
  Branches     214     214           
=====================================
+ Hits        1684    1687    +3     
+ Misses        65      64    -1     
Flag Coverage Δ
cpp 96.0% <100.0%> (+<0.1%) ⬆️
python 97.2% <ø> (ø)
Files Coverage Δ
include/checker/dd/DDEquivalenceChecker.hpp 100.0% <100.0%> (ø)
include/checker/dd/TaskManager.hpp 98.4% <100.0%> (+<0.1%) ⬆️
...checker/dd/applicationscheme/ApplicationScheme.hpp 100.0% <100.0%> (ø)
...dd/applicationscheme/GateCostApplicationScheme.hpp 95.2% <100.0%> (ø)
...d/applicationscheme/LookaheadApplicationScheme.hpp 100.0% <ø> (ø)
...pplicationscheme/ProportionalApplicationScheme.hpp 100.0% <ø> (ø)

... and 2 files with indirect coverage changes

@burgholzer burgholzer merged commit 4d1caad into main Jan 5, 2024
34 checks passed
@burgholzer burgholzer deleted the eliminate-reference-member branch January 5, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code code quality Anything related to code quality and code style. dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant