-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚸🚨 Eliminate reference members and improve TaskManager
interface
#349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burgholzer
added
dependencies
Pull requests that update a dependency file
submodules
Pull requests that update Submodules code
c++
Anything related to C++ code
code quality
Anything related to code quality and code style.
labels
Jan 5, 2024
burgholzer
added a commit
that referenced
this pull request
Jan 5, 2024
## Description This PR was triggered by the failures in #349 and its purpose is to better isolate the changes into separate PRs. - cda-tum/mqt-core#515 has dropped the submodules in `mqt-core` and replaced them with `FetchContent`. As such, the `googletest` test dependency is no longer available at its typical location. Consequently, this PR now also uses `FetchContent` to get `googletest`. In a future PR, this will most likely be extended to the `mqt-core` submodule as well. This should unblock #349. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. --------- Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
Signed-off-by: burgholzer <[email protected]>
burgholzer
force-pushed
the
eliminate-reference-member
branch
from
January 5, 2024 14:12
0c9c644
to
c18ddf4
Compare
burgholzer
changed the title
🚸🚨 Eliminate reference members and update
🚸🚨 Eliminate reference members and improve Jan 5, 2024
mqt-core
TaskManager
interface
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
=====================================
Coverage 96.2% 96.3%
=====================================
Files 34 34
Lines 1749 1751 +2
Branches 214 214
=====================================
+ Hits 1684 1687 +3
+ Misses 65 64 -1
|
Signed-off-by: burgholzer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c++
Anything related to C++ code
code quality
Anything related to code quality and code style.
dependencies
Pull requests that update a dependency file
submodules
Pull requests that update Submodules code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was triggered by a clang-tidy warning that popped up in #348.
This PR also adjusts the
TaskManager
interface to take a reference to a package instance instead of a unique pointer; making the interface more generic.This should unblock #348.
Checklist: