Move compression and decompression routines into dxtbx

[graeme-winter]

3rd time lucky...

[graeme-winter]

Selecting draft appears to reset target ...

[graeme-winter]

Question to reviewers: would it aid readability to express e.g.

    if ((-32767 <= delta) && (delta < 32768)) {
      s = (short)delta;
      b = ((u_s *)&s)[0].b;

      if (!le) {
        byte_swap_short(b);
      }

      packed.push_back(b[0]);
      packed.push_back(b[1]);
      current += delta;
      continue;
    }

in hex?

[graeme-winter]

Attempts to fix SConscript in keeping with dials one have now completely broken it \o/

Will revisit Monday

[graeme-winter]

Attempts to fix SConscript in keeping with dials one have now completely broken it \o/

Will revisit Monday

Wait, what? This fixed it 🤔

[graeme-winter]

OK, something weird here.

The tests were failing for me, passing in here.

I thought was my build being skewed so I have just made a clean bootstrap and ... still fails.

Lots of

E       Boost.Python.ArgumentError: Python argument types in
E           Scan.__init__(Scan, tuple, tuple, double, double, int, bool)
E       did not match C++ signature:
E           __init__(boost::python::api::object, scitbx::vec2<int> image_range, scitbx::vec2<double> oscillation, scitbx::af::shared<double> exposure_times, scitbx::af::shared<double> epochs, int batch_offset=0, bool deg=True)
E           __init__(boost::python::api::object, scitbx::vec2<int> image_range, scitbx::vec2<double> oscillation, int batch_offset=0, bool deg=True)
E           __init__(_object*, dxtbx::model::Scan)
E           __init__(_object*)

why is this not failing centrally?

[Anthchirp]

covered by tests skipped here because dials_regression?

[graeme-winter]

I have a clean build with no dials regression, so that is quite odd. Suspect it would fail in a clean build, but maybe the route for bootstrapping to where it got to with incremental builds is such that it has something built & linked.

Guess no-op changes to force rebuild could flush out some errors?

[Anthchirp]

You can force flushed cache builds by resetting the date in line 2 of .azure-pipelines.yml

[codecov]

Codecov Report

Merging #228 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
- Coverage   45.36%   45.36%   -0.01%     
==========================================
  Files         229      229              
  Lines       19200    19199       -1     
  Branches     2720     2720              
==========================================
- Hits         8711     8710       -1     
  Misses       9975     9975              
  Partials      514      514