Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GA small fix: Force cross-compilation for mac x86_64 on arm64 runners, under Intel emulation #388

Merged
merged 5 commits into from
Feb 5, 2025

Conversation

rwxayheee
Copy link
Collaborator

@joanimato Thanks for the fixes for GA. One minor problem with #385 was that both of the mac artifacts (from the arm64 and x86_64 workflows) have the arm64 architecture. This PR forces cross-compilation for the mac x86_64 executables to happen on arm64 runners, under Intel emulation.

Please take a quick look at the small changes and let me know if I'm doing the right thing. I will add the complied executables to the release tab, once this is merged

@rwxayheee rwxayheee requested a review from joanimato February 5, 2025 03:17
@joanimato
Copy link
Collaborator

Thanks. As long as the tests pass, this is fine by me.

@rwxayheee
Copy link
Collaborator Author

@joanimato Thanks!! I will take a second look at the failed builds on ubuntu. Sorry I didn't run all tests when I was testing it..

@rwxayheee
Copy link
Collaborator Author

I have the same PR in my fork with all checks passing here: https://github.com/rwxayheee/AutoDock-Vina/actions/runs/13149470972/job/36694214446?pr=7

I will rerun the Git Actions for this PR and make changes as needed

@rwxayheee
Copy link
Collaborator Author

In the first GA run, there was an unexpected segmentation fault during compilation for matrix.os == 'ubuntu-latest' && matrix.arch != 'x86_64'. But this is passing in the rerun, so the problem might be momentary.. Not changing the ubuntu workflows.

@joanimato If I could have your approval, I will be merging and adding the artifacts from this GA run to the release tab. Thanks again for taking care of this and the repo

Copy link
Collaborator

@joanimato joanimato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@rwxayheee rwxayheee merged commit be1689c into ccsb-scripps:develop Feb 5, 2025
8 checks passed
@rwxayheee rwxayheee deleted the GA_mac_x86 branch February 7, 2025 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants