fix: remove intial open on search undefined

ccontrols · Apr 27, 2021 · d9a06e7 · d9a06e7
1 parent 2f11249
commit d9a06e7
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/ui/components/src/SearchInput/SearchInput.tsx b/ui/components/src/SearchInput/SearchInput.tsx
@@ -91,9 +91,10 @@ export const SearchInput = <ItemType extends SearchInputItemType>({
       setIsOpen(newIsOpen && items.length > 0);
     }
   };
+  const hasSearch = !!search;
   useEffect(() => {
-    setIsOpen(items.length > 0 && search !== '');
-  }, [items, search]);
+    setIsOpen(items.length > 0 && hasSearch);
+  }, [items, hasSearch]);
 
   const updateSearch = async (newSearch: string) => {
     await onSearch(newSearch);