fix: update side context on tab change

ccontrols · Mar 14, 2021 · b85c625 · b85c625
1 parent 7d16d98
commit b85c625
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/ui/app/src/SideContext/SideContext.tsx b/ui/app/src/SideContext/SideContext.tsx
@@ -10,6 +10,7 @@ import {
 
 export interface SideContext {
   pageRef?: RefObject<HTMLDivElement>;
+  tab?: string;
 }
 interface ScrollElement {
   href: string;
@@ -19,7 +20,7 @@ interface ScrollElement {
   offset: number;
 }
 
-export const SideContext: FC<SideContext> = ({ pageRef }) => {
+export const SideContext: FC<SideContext> = ({ pageRef, tab }) => {
   const [items, setItems] = useState<ScrollElement[]>([]);
   const [activeItem, setActiveItem] = useState<number>(-1);
   const windRef = pageRef?.current;
@@ -80,7 +81,7 @@ export const SideContext: FC<SideContext> = ({ pageRef }) => {
     } else {
       setItems([]);
     }
-  }, [windRef]);
+  }, [windRef, tab]);
 
   useEffect(() => {
     if (typeof window !== 'undefined' && window) {

diff --git a/ui/app/src/SidebarsPage/SidebarsStoryPage.tsx b/ui/app/src/SidebarsPage/SidebarsStoryPage.tsx
@@ -156,7 +156,7 @@ export const SidebarsStoryPage: FC<DocPageProps> = ({
           </PageContainer>
         </Tabs>
       </Box>
-      {doc.contextSidebar && <SideContext pageRef={pageRef} />}
+      {doc.contextSidebar && <SideContext pageRef={pageRef} tab={activeTab} />}
     </Box>
   );
 };